Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752405AbbHCHgc (ORCPT ); Mon, 3 Aug 2015 03:36:32 -0400 Received: from mail-bl2on0143.outbound.protection.outlook.com ([65.55.169.143]:1741 "EHLO na01-bl2-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751933AbbHCHgY (ORCPT ); Mon, 3 Aug 2015 03:36:24 -0400 From: Liberman Igal To: Scott Wood CC: "devicetree@vger.kernel.org" , "linuxppc-dev@lists.ozlabs.org" , Madalin-Cristian Bucur , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan Thread-Topic: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for the FSL QorIQ DPAA FMan Thread-Index: AQHQyqLiJ+OUWBAG4UKRuko3yBkTi530b06AgAV4kkA= Date: Mon, 3 Aug 2015 07:36:22 +0000 Message-ID: References: <1438230764-10951-1-git-send-email-igal.liberman@freescale.com> <1438286389.2993.365.camel@freescale.com> In-Reply-To: <1438286389.2993.365.camel@freescale.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: freescale.com; dkim=none (message not signed) header.d=none; x-originating-ip: [192.88.162.1] x-microsoft-exchange-diagnostics: 1;DM2PR03MB557;5:FnFovra1oINsMgWfYuDC8Q14TRcohJdVaVwardnePS/D2TxkNkwfOobxLf/2n5hmMKsVzgbzD8kRF0JkVv6ABZDE1B+qy/X01Ag+JYRKwJHpghPEuDMb3568Laz70nsDM1wiICJsx8rBpX0WHpBNpQ==;24:FxYoYrBmX9wqZdqQL/YUbwe64NXbZS9uqEsYCc3Nl94w6dX1O5E5M7/7rOdAmP5q+Bqw54nHFcj5ZakgTavv8oxU6eZCKhd+NqWl5vwdhQ4=;20:QMrE3P/DoYWQZYDI3xTvJtgsuorHw4pLc9sSvl4TNR1wXmN/87reOi6WsomopVY/PdU9mEPC+iEywHNMmbpv8w== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB557; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DM2PR03MB557;BCL:0;PCL:0;RULEID:;SRVR:DM2PR03MB557; x-forefront-prvs: 0657D528EC x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(13464003)(377454003)(24454002)(377424004)(74316001)(575784001)(99286002)(106116001)(102836002)(77096005)(86362001)(33656002)(76176999)(87936001)(5002640100001)(50986999)(2656002)(54356999)(2950100001)(189998001)(2900100001)(66066001)(76576001)(110136002)(5001960100002)(62966003)(19580405001)(77156002)(5003600100002)(4001450100002)(92566002)(5001920100001)(40100003)(122556002)(46102003)(19580395003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM2PR03MB557;H:DM2PR03MB509.namprd03.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: freescale.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2015 07:36:22.3111 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 710a03f5-10f6-4d38-9ff4-a80b81da590d X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR03MB557 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t737aiKq023903 Content-Length: 1256 Lines: 39 Regards, Igal Liberman. > -----Original Message----- > From: Wood Scott-B07421 > Sent: Thursday, July 30, 2015 11:00 PM > To: Liberman Igal-B31950 > Cc: devicetree@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; Bucur > Madalin-Cristian-B32716; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 1/2] powerpc/mpc85xx: Create dts components for > the FSL QorIQ DPAA FMan > > On Thu, 2015-07-30 at 07:32 +0300, Igal.Liberman wrote: > > +fman0: fman@400000{ > > + #address-cells = <1>; > > + #size-cells = <1>; > > + cell-index = <0>; > > + compatible = "fsl,fman"; > > + ranges = <0 0x400000 0x100000>; > > + reg = <0x400000 0x100000>; > > + interrupts = <96 2 0 0>, <16 2 1 1>; > > + clocks = <&clockgen 3 0>; > > + clock-names = "fm0clk"; > > clock-names should be "fmanclk" as per the binding. And why would you > want the driver to have to encode the fman index into the name in order to > look the clock up by name? > Well, yes, this should be "fmanclk". The driver doesn't need to know the index. I'll fix that and re-submit. Igal. > -Scott ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?