Message-ID: <1438588697.30149.12.camel@perches.com>
Subject: Re: [PATCH V2]  staging: android: lowmemorykiller: imporve lmk to
 avoid deadlock issue
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "Wang, Biao" <biao.wang@intel.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "arve@android.com" <arve@android.com>,
        "riandrews@android.com" <riandrews@android.com>,
        "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Zhang, Di" <di.zhang@intel.com>, "Li, Fei" <fei.li@intel.com>
Date: Mon, 03 Aug 2015 00:58:17 -0700
In-Reply-To: <20150803061556.GS5096@mwanda>
References: <09CB0B4607EB8F4DB7E0BE3B06BFBD051DA2E849@SHSMSX101.ccr.corp.intel.com>
	 <20150803061556.GS5096@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1324
Lines: 35

On Mon, 2015-08-03 at 09:15 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 05:53:22AM +0000, Wang, Biao wrote:
> > Consider the following case:
> > Task A trigger lmk with a lock held, while task B try to
> > get this lock, but unfortunately B is the very culprit task lmk 
> > select to
> > kill. Then B will never be killed, and A will forever select B to 
> > kill.
> > Such dead lock will trigger softlock up issue.
> > 
> > This patch try to pick the next task to break this loop.
> > 
> > Signed-off-by: Wang Biao <biao.wang@intel.com>
> > Reviewed-by: Zhang Di <di.zhang@intel.com>
> > Reviewed-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> I don't really feel comfortable saying I reviewed this code.  I just
> commented on a few process issues.  I don't know the subsystem well
> enough to give it a seal of approval.
> 
> > Reviewed-by: Joe Perches <joe@perches.com>

Please don't say I reviewed this either.

I may have commented on it, but I certainly
did't add a "Reviewed-by" signature.

Please don't add signatures unless people
specifically state so.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/