Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752304AbbHCIHK (ORCPT ); Mon, 3 Aug 2015 04:07:10 -0400 Received: from mail-ob0-f170.google.com ([209.85.214.170]:35578 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751838AbbHCIHH convert rfc822-to-8bit (ORCPT ); Mon, 3 Aug 2015 04:07:07 -0400 MIME-Version: 1.0 In-Reply-To: <1438241239-15178-1-git-send-email-shaveta@freescale.com> References: <1438241239-15178-1-git-send-email-shaveta@freescale.com> Date: Mon, 3 Aug 2015 10:07:06 +0200 Message-ID: Subject: Re: [PATCH 1/3] drivers/gpio: Port gpio driver to ls1021a-qds platform From: Linus Walleij To: Shaveta Leekha , Alexander Stein , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= Cc: "linux-kernel@vger.kernel.org" , "linux-gpio@vger.kernel.org" , r64188@freescale.com, Alexandre Courbot Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 35 Alexander Stein and Uwe Kleine-König are working on this driver for this kernel cycle so requesting their help in reviewing these three patches. Alexander/Uwe: can you see the patches, or will Shaveta need to resend them? On Thu, Jul 30, 2015 at 9:27 AM, Shaveta Leekha wrote: > LS1021a-qds has the same ip block/controller as > GPIO on powerpc platform(MPC8XXX). > > So use portable i/o accessors, as in_be32/out_be32 > accessors are Power architecture specific whereas > ioread/writebe32 are available in other architectures. > > GPIO controller's registers are big endian, the > accessors ioread32be/iowrite32be matches this one > and portable on powerpc as well on ARM. > > Signed-off-by: Shaveta Leekha > --- > Tested on Freescale SDK 1.8, as LS1021aQDS support is not yet complete in upstream Do you mean that Freescale has synthesized this GPIO controller on ARM LE too? In that case that is very useful information that should go into the commit message. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/