Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752606AbbHCIPy (ORCPT ); Mon, 3 Aug 2015 04:15:54 -0400 Received: from mx2.suse.de ([195.135.220.15]:53304 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751522AbbHCIPw (ORCPT ); Mon, 3 Aug 2015 04:15:52 -0400 Date: Mon, 03 Aug 2015 10:15:50 +0200 Message-ID: From: Takashi Iwai To: "Tomer Barletz" Cc: , , , Subject: Re: [PATCH] Fix logical-not-parentheses warning In-Reply-To: <1438506537-26743-1-git-send-email-barletz@gmail.com> References: <1438506537-26743-1-git-send-email-barletz@gmail.com> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka) FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/24.5 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1232 Lines: 39 On Sun, 02 Aug 2015 11:08:57 +0200, Tomer Barletz wrote: > > This fixes the following warning, that is seen with gcc 5.1: > warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]. > > Signed-off-by: Tomer Barletz Applied, thanks. Takashi > --- > sound/pci/oxygen/oxygen_mixer.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/sound/pci/oxygen/oxygen_mixer.c b/sound/pci/oxygen/oxygen_mixer.c > index 6492bca..4ca1266 100644 > --- a/sound/pci/oxygen/oxygen_mixer.c > +++ b/sound/pci/oxygen/oxygen_mixer.c > @@ -88,7 +88,7 @@ static int dac_mute_put(struct snd_kcontrol *ctl, > int changed; > > mutex_lock(&chip->mutex); > - changed = !value->value.integer.value[0] != chip->dac_mute; > + changed = (!value->value.integer.value[0]) != chip->dac_mute; > if (changed) { > chip->dac_mute = !value->value.integer.value[0]; > chip->model.update_dac_mute(chip); > -- > 2.4.3 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/