Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752351AbbHCJAl (ORCPT ); Mon, 3 Aug 2015 05:00:41 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:33193 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751288AbbHCJAj (ORCPT ); Mon, 3 Aug 2015 05:00:39 -0400 MIME-Version: 1.0 In-Reply-To: <55BE72C5.5020900@gmx.de> References: <55BE5483.6080509@kernel.org> <55BE72C5.5020900@gmx.de> Date: Mon, 3 Aug 2015 12:00:38 +0300 Message-ID: Subject: Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs From: Cristina Georgiana Opriceana To: Hartmut Knaack Cc: Jonathan Cameron , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , linux-kernel@vger.kernel.org, Daniel Baluta Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2323 Lines: 62 On Sun, Aug 2, 2015 at 10:43 PM, Hartmut Knaack wrote: > > Jonathan Cameron schrieb am 02.08.2015 um 19:33: > > On 24/07/15 14:21, Cristina Opriceana wrote: > >> Fix kernel docs warnings by adding the missing fields, > >> each with its associated description. > >> > >> Signed-off-by: Cristina Opriceana > > Applied. Thanks > > > > Jonathan > >> --- > >> drivers/iio/industrialio-event.c | 6 ++++++ > >> 1 file changed, 6 insertions(+) > >> > >> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c > >> index 894d813..b2f63f9 100644 > >> --- a/drivers/iio/industrialio-event.c > >> +++ b/drivers/iio/industrialio-event.c > >> @@ -32,6 +32,7 @@ > >> * @dev_attr_list: list of event interface sysfs attribute > >> * @flags: file operations related flags including busy flag. > >> * @group: event interface sysfs attribute group > >> + * @read_lock: lock to protect kfifo read operations > >> */ > >> struct iio_event_interface { > >> wait_queue_head_t wait; > >> @@ -75,6 +76,11 @@ EXPORT_SYMBOL(iio_push_event); > >> > >> /** > >> * iio_event_poll() - poll the event queue to find out if it has data > >> + * @filep: File structure pointer to identify the device > >> + * @wait: Poll table pointer to add the wait queue on > >> + * > >> + * Return: (POLLIN | POLLRDNORM) if data is available for reading > >> + * or a negative error code on failure > > This can also return 0 if no data is available. > > Actually, being unsigned int, the intended negative error code won't > appear - ouch! Any volunteers to address this issue? Ah, sorry. Missed that. I'll fix it. Cristina > >> */ > >> static unsigned int iio_event_poll(struct file *filep, > >> struct poll_table_struct *wait) > >> > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/