Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752788AbbHCJFc (ORCPT ); Mon, 3 Aug 2015 05:05:32 -0400 Received: from smtp-out-139.synserver.de ([212.40.185.139]:1051 "EHLO smtp-out-139.synserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752694AbbHCJF3 (ORCPT ); Mon, 3 Aug 2015 05:05:29 -0400 X-SynServer-TrustedSrc: 1 X-SynServer-AuthUser: lars@metafoo.de X-SynServer-PPID: 13145 Message-ID: <55BF2ED5.60104@metafoo.de> Date: Mon, 03 Aug 2015 11:05:25 +0200 From: Lars-Peter Clausen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.7.0 MIME-Version: 1.0 To: Hartmut Knaack , Jonathan Cameron , Cristina Opriceana CC: pmeerw@pmeerw.net, linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, daniel.baluta@intel.com Subject: Re: [PATCH 4/6] iio: event: Add missing fields in kernel docs References: <55BE5483.6080509@kernel.org> <55BE72C5.5020900@gmx.de> In-Reply-To: <55BE72C5.5020900@gmx.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1949 Lines: 51 On 08/02/2015 09:43 PM, Hartmut Knaack wrote: > Jonathan Cameron schrieb am 02.08.2015 um 19:33: >> On 24/07/15 14:21, Cristina Opriceana wrote: >>> Fix kernel docs warnings by adding the missing fields, >>> each with its associated description. >>> >>> Signed-off-by: Cristina Opriceana >> Applied. Thanks >> >> Jonathan >>> --- >>> drivers/iio/industrialio-event.c | 6 ++++++ >>> 1 file changed, 6 insertions(+) >>> >>> diff --git a/drivers/iio/industrialio-event.c b/drivers/iio/industrialio-event.c >>> index 894d813..b2f63f9 100644 >>> --- a/drivers/iio/industrialio-event.c >>> +++ b/drivers/iio/industrialio-event.c >>> @@ -32,6 +32,7 @@ >>> * @dev_attr_list: list of event interface sysfs attribute >>> * @flags: file operations related flags including busy flag. >>> * @group: event interface sysfs attribute group >>> + * @read_lock: lock to protect kfifo read operations >>> */ >>> struct iio_event_interface { >>> wait_queue_head_t wait; >>> @@ -75,6 +76,11 @@ EXPORT_SYMBOL(iio_push_event); >>> >>> /** >>> * iio_event_poll() - poll the event queue to find out if it has data >>> + * @filep: File structure pointer to identify the device >>> + * @wait: Poll table pointer to add the wait queue on >>> + * >>> + * Return: (POLLIN | POLLRDNORM) if data is available for reading >>> + * or a negative error code on failure > > This can also return 0 if no data is available. > > Actually, being unsigned int, the intended negative error code won't > appear - ouch! Any volunteers to address this issue? Sorry, my fault. It looks like the poll() callback can't return a error. So if no device is bound we should just return 0. - Lars -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/