Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752655AbbHCJIZ (ORCPT ); Mon, 3 Aug 2015 05:08:25 -0400 Received: from bombadil.infradead.org ([198.137.202.9]:41054 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbbHCJIY (ORCPT ); Mon, 3 Aug 2015 05:08:24 -0400 Date: Mon, 3 Aug 2015 11:08:07 +0200 From: Peter Zijlstra To: Alexander Shishkin Cc: Takao Indoh , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Arnaldo Carvalho de Melo , linux-kernel@vger.kernel.org, x86@kernel.org Subject: Re: [PATCH] x86: Clean up files of Intel Processor Trace Message-ID: <20150803090807.GG25159@twins.programming.kicks-ass.net> References: <1438589411-6104-1-git-send-email-indou.takao@jp.fujitsu.com> <874mkg7nhq.fsf@ashishki-desk.ger.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <874mkg7nhq.fsf@ashishki-desk.ger.corp.intel.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1262 Lines: 34 On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: > Takao Indoh writes: > Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a > property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but > 12 is not always PAGE_SHIFT. PAGE_SHIFT is _always_ 12 on x86. Changing that will require changing the page table format, a rather unlikely thing to go happen. > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_pt.c b/arch/x86/kernel/cpu/perf_event_intel_pt.c > > index 183de71..1e7d89e 100644 > > --- a/arch/x86/kernel/cpu/perf_event_intel_pt.c > > +++ b/arch/x86/kernel/cpu/perf_event_intel_pt.c > > @@ -37,9 +37,9 @@ static struct pt_pmu pt_pmu; > > > > enum cpuid_regs { > > CR_EAX = 0, > > + CR_EBX, > > CR_ECX, > > - CR_EDX, > > - CR_EBX > > + CR_EDX > > }; > > This doesn't seem necessary. For those of us suffering OCDs and all, its a good change though. The alfabet song does go: A, B, C, D etc.. after all. Not: A, C, D, B ... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/