Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752961AbbHCJkZ (ORCPT ); Mon, 3 Aug 2015 05:40:25 -0400 Received: from www.linutronix.de ([62.245.132.108]:60080 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751982AbbHCJkY (ORCPT ); Mon, 3 Aug 2015 05:40:24 -0400 Date: Mon, 3 Aug 2015 11:40:05 +0200 (CEST) From: Thomas Gleixner To: Rusty Russell cc: LKML , x86@kernel.org, Jiang Liu , Peter Zijlstra , Bjorn Helgaas Subject: Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors In-Reply-To: <87pp356qaz.fsf@rustcorp.com.au> Message-ID: References: <20150802203427.110728870@linutronix.de> <20150802203609.302168886@linutronix.de> <87pp356qaz.fsf@rustcorp.com.au> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1258 Lines: 44 On Mon, 3 Aug 2015, Rusty Russell wrote: > Thomas Gleixner writes: > > + > > + /* Some systems map "vectors" to interrupts weirdly. Not us! */ > > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq); > > Missing ]. Doh. > [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1) > > You broke interrupts :( Right, because I missed the other place which fiddles with interrupts. Does the patch below fix the issue? Thanks, tglx ----------------> Index: tip/arch/x86/lguest/boot.c =================================================================== --- tip.orig/arch/x86/lguest/boot.c +++ tip/arch/x86/lguest/boot.c @@ -841,8 +841,7 @@ static int lguest_enable_irq(struct pci_ /* We literally use the PCI interrupt line as the irq number. */ pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &line); - irq_set_chip_and_handler_name(line, &lguest_irq_controller, - handle_level_irq, "level"); + lguest_setup_irq(line); dev->irq = line; return 0; } -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/