Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752423AbbHCJoQ (ORCPT ); Mon, 3 Aug 2015 05:44:16 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:36150 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751756AbbHCJoP (ORCPT ); Mon, 3 Aug 2015 05:44:15 -0400 MIME-Version: 1.0 In-Reply-To: <20150803090807.GG25159@twins.programming.kicks-ass.net> References: <1438589411-6104-1-git-send-email-indou.takao@jp.fujitsu.com> <874mkg7nhq.fsf@ashishki-desk.ger.corp.intel.com> <20150803090807.GG25159@twins.programming.kicks-ass.net> Date: Mon, 3 Aug 2015 12:44:13 +0300 X-Google-Sender-Auth: vnZQueF4oBsrg1nhJEVGL6vui7w Message-ID: Subject: Re: [PATCH] x86: Clean up files of Intel Processor Trace From: Alexander Shishkin To: Peter Zijlstra Cc: Alexander Shishkin , Takao Indoh , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Arnaldo Carvalho de Melo , Linux Kernel Mailing List , x86@kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 925 Lines: 24 On 3 August 2015 at 12:08, Peter Zijlstra wrote: > On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: >> Takao Indoh writes: > >> Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a >> property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but >> 12 is not always PAGE_SHIFT. > > PAGE_SHIFT is _always_ 12 on x86. Changing that will require changing > the page table format, a rather unlikely thing to go happen. Of course. Yet that doesn't justify turning every 12 into PAGE_SHIFT is what I'm saying. Oh, look, it's PAGE_SHIFT o'clock on x86, time for lunch. :) Regards, -- Alex -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/