Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753096AbbHCKlP (ORCPT ); Mon, 3 Aug 2015 06:41:15 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:37807 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbbHCKlN (ORCPT ); Mon, 3 Aug 2015 06:41:13 -0400 Date: Mon, 3 Aug 2015 13:41:10 +0300 From: "Kirill A. Shutemov" To: Jerome Marchand Cc: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Dave Hansen , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv9 25/36] mm, thp: remove infrastructure for handling splitting PMDs Message-ID: <20150803104110.GA25034@node.dhcp.inet.fi> References: <1437402069-105900-1-git-send-email-kirill.shutemov@linux.intel.com> <1437402069-105900-26-git-send-email-kirill.shutemov@linux.intel.com> <55BB8DB2.9010804@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55BB8DB2.9010804@redhat.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1436 Lines: 37 On Fri, Jul 31, 2015 at 05:01:06PM +0200, Jerome Marchand wrote: > On 07/20/2015 04:20 PM, Kirill A. Shutemov wrote: > > @@ -1616,23 +1605,14 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, > > * Note that if it returns 1, this routine returns without unlocking page > > * table locks. So callers must unlock them. > > */ > > The comment above should be updated. Like this? diff --git a/mm/huge_memory.c b/mm/huge_memory.c index d32277463932..78a6c7cdf8f7 100644 --- a/mm/huge_memory.c +++ b/mm/huge_memory.c @@ -1627,11 +1627,10 @@ int change_huge_pmd(struct vm_area_struct *vma, pmd_t *pmd, } /* - * Returns 1 if a given pmd maps a stable (not under splitting) thp. - * Returns -1 if it maps a thp under splitting. Returns 0 otherwise. + * Returns true if a given pmd maps a thp, false otherwise. * - * Note that if it returns 1, this routine returns without unlocking page - * table locks. So callers must unlock them. + * Note that if it returns true, this routine returns without unlocking page + * table lock. So callers must unlock it. */ bool __pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma, spinlock_t **ptl) -- Kirill A. Shutemov -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/