Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753140AbbHCKoF (ORCPT ); Mon, 3 Aug 2015 06:44:05 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:36371 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752744AbbHCKoD (ORCPT ); Mon, 3 Aug 2015 06:44:03 -0400 MIME-Version: 1.0 In-Reply-To: <4193254d1067149430a5a8d84a21def37f09bcec.1438598039.git.cristina.opriceana@gmail.com> References: <4193254d1067149430a5a8d84a21def37f09bcec.1438598039.git.cristina.opriceana@gmail.com> Date: Mon, 3 Aug 2015 13:44:00 +0300 X-Google-Sender-Auth: trZ1vCs-ktMo2kS89ElUgfm7xbE Message-ID: Subject: Re: [PATCH] iio: industrialio-buffer: Fix iio_buffer_poll return value From: Daniel Baluta To: Cristina Opriceana Cc: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald , "linux-iio@vger.kernel.org" , Linux Kernel Mailing List , Daniel Baluta Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1947 Lines: 50 On Mon, Aug 3, 2015 at 1:37 PM, Cristina Opriceana wrote: > Change return value to 0 if no device is bound since > unsigned int cannot support negative error codes. > > Signed-off-by: Cristina Opriceana Fixes: f18e7a068 ("iio: Return -ENODEV for file operations if the device has been unregistered") > --- > drivers/iio/industrialio-buffer.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/industrialio-buffer.c b/drivers/iio/industrialio-buffer.c > index faed6ef..e8e87cf 100644 > --- a/drivers/iio/industrialio-buffer.c > +++ b/drivers/iio/industrialio-buffer.c > @@ -155,7 +155,9 @@ ssize_t iio_buffer_read_first_n_outer(struct file *filp, char __user *buf, > * a wait queue > * > * Return: (POLLIN | POLLRDNORM) if data is available for reading > - * or 0 for other cases > + * and 0 for other cases, e.g. no device is bound or no > + * hardware fifo flush could be triggered. > + * > */ > unsigned int iio_buffer_poll(struct file *filp, > struct poll_table_struct *wait) > @@ -164,7 +166,7 @@ unsigned int iio_buffer_poll(struct file *filp, > struct iio_buffer *rb = indio_dev->buffer; > > if (!indio_dev->info) > - return -ENODEV; > + return 0; > > poll_wait(filp, &rb->pollq, wait); > if (iio_buffer_ready(indio_dev, rb, rb->watermark, 0)) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/