Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753083AbbHCLlA (ORCPT ); Mon, 3 Aug 2015 07:41:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:58855 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752022AbbHCLk7 (ORCPT ); Mon, 3 Aug 2015 07:40:59 -0400 Message-ID: <55BF5340.4080008@redhat.com> Date: Mon, 03 Aug 2015 13:40:48 +0200 From: Jerome Marchand User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: "Kirill A. Shutemov" , Andrew Morton , Andrea Arcangeli , Hugh Dickins , Dave Hansen , Mel Gorman , Rik van Riel , Vlastimil Babka , Christoph Lameter , Naoya Horiguchi , Steve Capper , "Aneesh Kumar K.V" , Johannes Weiner , Michal Hocko , Sasha Levin , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCHv9 25/36] mm, thp: remove infrastructure for handling splitting PMDs References: <1437402069-105900-1-git-send-email-kirill.shutemov@linux.intel.com> <1437402069-105900-26-git-send-email-kirill.shutemov@linux.intel.com> <55BB8DB2.9010804@redhat.com> <20150803104110.GA25034@node.dhcp.inet.fi> In-Reply-To: <20150803104110.GA25034@node.dhcp.inet.fi> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="duiOcwInaXQn40A3R4tvh6CbkIdrogXvi" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2452 Lines: 71 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --duiOcwInaXQn40A3R4tvh6CbkIdrogXvi Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 08/03/2015 12:41 PM, Kirill A. Shutemov wrote: > On Fri, Jul 31, 2015 at 05:01:06PM +0200, Jerome Marchand wrote: >> On 07/20/2015 04:20 PM, Kirill A. Shutemov wrote: >>> @@ -1616,23 +1605,14 @@ int change_huge_pmd(struct vm_area_struct *vm= a, pmd_t *pmd, >>> * Note that if it returns 1, this routine returns without unlocking= page >>> * table locks. So callers must unlock them. >>> */ >> >> The comment above should be updated. >=20 > Like this? Yes. Thanks. >=20 > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > index d32277463932..78a6c7cdf8f7 100644 > --- a/mm/huge_memory.c > +++ b/mm/huge_memory.c > @@ -1627,11 +1627,10 @@ int change_huge_pmd(struct vm_area_struct *vma,= pmd_t *pmd, > } > =20 > /* > - * Returns 1 if a given pmd maps a stable (not under splitting) thp. > - * Returns -1 if it maps a thp under splitting. Returns 0 otherwise. > + * Returns true if a given pmd maps a thp, false otherwise. > * > - * Note that if it returns 1, this routine returns without unlocking p= age > - * table locks. So callers must unlock them. > + * Note that if it returns true, this routine returns without unlockin= g page > + * table lock. So callers must unlock it. > */ > bool __pmd_trans_huge_lock(pmd_t *pmd, struct vm_area_struct *vma, > spinlock_t **ptl) >=20 --duiOcwInaXQn40A3R4tvh6CbkIdrogXvi Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBCAAGBQJVv1NEAAoJEHTzHJCtsuoC/UEH/i1nFIaNWqqsG1jodKuBtois ywnvcAxRVWce6O7KcyjCrQjqoZ+0xc/NLHYwEsSuncNYYLsllOKdy5+0GAJlYSfD k4Kg9m1iILb4bQTgfahKG46egEGmPqqhLnjlXC2t/Bk37wrSKUbr2lTGRIa7RaGl ddvbnC+WMtzy/hJgg1maSjXfjKjKb9zy4s4g1ewhwKImXd8JVB29iu9LJadwxLCt 2mzu2SFUmSsCfLH6AnG5wSDepMr71kXGD09fQ7vsXbvBzUkBaqTFXT+9zEjvjshn LgcREuQnjd2daBSsRJVbZlfBEKKVZm5OsMMk5QkoZn9OrYbIcfyk9fAktEE0cyM= =Ukhq -----END PGP SIGNATURE----- --duiOcwInaXQn40A3R4tvh6CbkIdrogXvi-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/