Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753422AbbHCLp7 (ORCPT ); Mon, 3 Aug 2015 07:45:59 -0400 Received: from mail-pd0-f173.google.com ([209.85.192.173]:36313 "EHLO mail-pd0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752121AbbHCLpq (ORCPT ); Mon, 3 Aug 2015 07:45:46 -0400 Date: Mon, 3 Aug 2015 17:15:34 +0530 From: Sudip Mukherjee To: Daniel Vetter , Jani Nikula , David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v2] drm/i915: load driver even if debugfs fails Message-ID: <20150803114534.GA3123@sudip-pc> References: <1437660372-14679-1-git-send-email-sudipm.mukherjee@gmail.com> <20150803092642.GA1371@sudip-pc> <20150803105433.GC24689@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803105433.GC24689@phenom.ffwll.local> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1040 Lines: 22 On Mon, Aug 03, 2015 at 12:54:33PM +0200, Daniel Vetter wrote: > On Mon, Aug 03, 2015 at 02:56:42PM +0530, Sudip Mukherjee wrote: > > On Thu, Jul 23, 2015 at 07:36:12PM +0530, Sudip Mukherjee wrote: > > > debugfs files are not necessary for the usual operation of the driver > > > and the device. No need to check for the return values from the debugfs > > > file creation. Even if one debugfs file fails to create we try with the > > > next debugfs file and ultimately return success always so that the > > > driver continues to load. > > Does this even happen? realistically - I don't think it can happen. Even if it happens then there will be more serious problem like memory crunch or filesystem problem and in those cases there is no point in continuing to load the driver. regards sudip -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/