Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753267AbbHCMKj (ORCPT ); Mon, 3 Aug 2015 08:10:39 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:18632 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752899AbbHCMKi (ORCPT ); Mon, 3 Aug 2015 08:10:38 -0400 Date: Mon, 3 Aug 2015 15:09:45 +0300 From: Dan Carpenter To: Joe Perches Cc: "devel@driverdev.osuosl.org" , "tinajohnson.1234@gmail.com" , "gregkh@linuxfoundation.org" , "lambert.quentin@gmail.com" , "linux-kernel@vger.kernel.org" , "fabio.falzoi84@gmail.com" , "roxanagabriela10@gmail.com" , "vatikaharlalka@gmail.com" , "Shah, Yash (Y.)" , "contact@timothyleung.co" Subject: Re: [PATCH] Staging: rts5208: Fix code indentation warning as detected by checkpatch.pl Message-ID: <20150803120945.GX5180@mwanda> References: <20150803111826.GA5293@ubuntu> <20150803113357.GW5180@mwanda> <1438602100.30149.20.camel@perches.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438602100.30149.20.camel@perches.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 930 Lines: 27 On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote: > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote: > > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote: > > > From: Yash Shah > > > > > > Fixed code indentation warning as detected by checkpatch.pl. > > > > > > Signed-off-by: Yash Shah > > > > Defines aren't allowed in .c files anyway. > > The kernel source tree disagrees with you > > $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l > 175830 Duh. Sorry. I meant ifdefs. I'm sure you can find lots of examples of those too, but this code would be cleaner without the ifdefs. regards, dan carpenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/