Message-ID: <1438604297.30149.29.camel@perches.com>
Subject: Re: [PATCH] Staging: rts5208: Fix code indentation warning as
 detected by checkpatch.pl
From: Joe Perches <joe@perches.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: "devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
        "tinajohnson.1234@gmail.com" <tinajohnson.1234@gmail.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "lambert.quentin@gmail.com" <lambert.quentin@gmail.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "fabio.falzoi84@gmail.com" <fabio.falzoi84@gmail.com>,
        "roxanagabriela10@gmail.com" <roxanagabriela10@gmail.com>,
        "vatikaharlalka@gmail.com" <vatikaharlalka@gmail.com>,
        "Shah, Yash (Y.)" <yshah1@visteon.com>,
        "contact@timothyleung.co" <contact@timothyleung.co>
Date: Mon, 03 Aug 2015 05:18:17 -0700
In-Reply-To: <20150803120945.GX5180@mwanda>
References: <20150803111826.GA5293@ubuntu> <20150803113357.GW5180@mwanda>
	 <1438602100.30149.20.camel@perches.com> <20150803120945.GX5180@mwanda>
Content-Type: text/plain; charset="ISO-8859-1"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1088
Lines: 30

On Mon, 2015-08-03 at 15:09 +0300, Dan Carpenter wrote:
> On Mon, Aug 03, 2015 at 04:41:40AM -0700, Joe Perches wrote:
> > On Mon, 2015-08-03 at 14:33 +0300, Dan Carpenter wrote:
> > > On Mon, Aug 03, 2015 at 11:18:31AM +0000, Shah, Yash (Y.) wrote:
> > > > From: Yash Shah <yshah1@visteon.com>
> > > > 
> > > > Fixed code indentation warning as detected by checkpatch.pl.
> > > > 
> > > > Signed-off-by: Yash Shah <yshah1@visteon.com>
> > > 
> > > Defines aren't allowed in .c files anyway.
> > 
> > The kernel source tree disagrees with you
> > 
> > $ git grep "^\s*#\s*define\b" -- "*.c" | wc -l
> > 175830
> 
> Duh.  Sorry.  I meant ifdefs.  I'm sure you can find lots of examples
> of those too,

Yeah, no worries, only about 30k of those.

>  but this code would be cleaner without the ifdefs.

Very true.  Removing these would be good.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/