Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753808AbbHCMn5 (ORCPT ); Mon, 3 Aug 2015 08:43:57 -0400 Received: from casper.infradead.org ([85.118.1.10]:48291 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753366AbbHCMn4 (ORCPT ); Mon, 3 Aug 2015 08:43:56 -0400 Date: Mon, 3 Aug 2015 14:43:50 +0200 From: Peter Zijlstra To: Frederic Weisbecker Cc: LKML , Thomas Gleixner , Preeti U Murthy , Christoph Lameter , Ingo Molnar , Viresh Kumar , Rik van Riel Subject: Re: [PATCH 05/10] nohz: New tick dependency mask Message-ID: <20150803124350.GH19282@twins.programming.kicks-ass.net> References: <1437669735-8786-1-git-send-email-fweisbec@gmail.com> <1437669735-8786-6-git-send-email-fweisbec@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1437669735-8786-6-git-send-email-fweisbec@gmail.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 780 Lines: 23 On Thu, Jul 23, 2015 at 06:42:10PM +0200, Frederic Weisbecker wrote: > +unsigned long __tick_nohz_set_tick_dependency(enum tick_dependency_bit bit, > + unsigned long *dep) > +{ > + unsigned long prev; > + unsigned long old = *dep; > + unsigned long mask = BIT_MASK(bit); > + > + while ((prev = cmpxchg(dep, old, old | mask)) != old) { > + old = prev; > + cpu_relax(); > + } > + > + return prev; > +} That's typically called a fetch_or(). The function name, which is entirely too long, also doesn't suggest a return value. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/