Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932065AbbHCNLs (ORCPT ); Mon, 3 Aug 2015 09:11:48 -0400 Received: from mx1.redhat.com ([209.132.183.28]:53552 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753232AbbHCNLq (ORCPT ); Mon, 3 Aug 2015 09:11:46 -0400 Subject: Re: [linux-sunxi] Re: [PATCH v2] ARM: dts: sunxi: Add regulators for LeMaker BananaPi To: maxime.ripard@free-electrons.com, Timo Sigurdsson References: <1438532305-5884-1-git-send-email-public_timo.s@silentcreek.de> <20150803094723.GD2564@lukather> Cc: robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, ijc+devicetree@hellion.org.uk, galak@codeaurora.org, linux@arm.linux.org.uk, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com, wens@csie.org From: Hans de Goede Message-ID: <55BF688D.5010905@redhat.com> Date: Mon, 3 Aug 2015 15:11:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <20150803094723.GD2564@lukather> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2607 Lines: 98 Hi, On 03-08-15 11:47, Maxime Ripard wrote: > On Sun, Aug 02, 2015 at 06:18:25PM +0200, Timo Sigurdsson wrote: >> sun7i-a20-bananapi.dts doesn't contain regulator nodes for the AXP209 PMU >> driver, so add them to allow for voltage-scaling with cpufreq-dt. >> >> Signed-off-by: Timo Sigurdsson >> --- >> Changes since v1 (RFC): >> >> - Dropped the changes to the cpufreq operating points and renamed the patch >> accordingly >> - Limited the CPU voltage range so it doesn't exceed the SOC specifications >> --- >> arch/arm/boot/dts/sun7i-a20-bananapi.dts | 35 ++++++++++++++++++++++++++++---- >> 1 file changed, 31 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/sun7i-a20-bananapi.dts b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> index 9f7b472..74382f3 100644 >> --- a/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> +++ b/arch/arm/boot/dts/sun7i-a20-bananapi.dts >> @@ -92,6 +92,10 @@ >> status = "okay"; >> }; >> >> +&cpu0 { >> + cpu-supply = <®_dcdc2>; >> +}; >> + >> &ehci0 { >> status = "okay"; >> }; >> @@ -119,13 +123,9 @@ >> status = "okay"; >> >> axp209: pmic@34 { >> - compatible = "x-powers,axp209"; >> reg = <0x34>; >> interrupt-parent = <&nmi_intc>; >> interrupts = <0 IRQ_TYPE_LEVEL_LOW>; >> - >> - interrupt-controller; >> - #interrupt-cells = <1>; >> }; >> }; >> >> @@ -182,6 +182,33 @@ >> }; >> }; >> >> +#include "axp209.dtsi" >> + >> +®_dcdc2 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-cpu"; >> +}; >> + >> +®_dcdc3 { >> + regulator-always-on; >> + regulator-min-microvolt = <1000000>; >> + regulator-max-microvolt = <1400000>; >> + regulator-name = "vdd-int-dll"; >> +}; >> + >> +®_ldo1 { >> + regulator-name = "vdd-rtc"; >> +}; >> + >> +®_ldo2 { >> + regulator-always-on; >> + regulator-min-microvolt = <3000000>; >> + regulator-max-microvolt = <3000000>; >> + regulator-name = "avcc"; >> +}; > > What regulator provides the 3.3V regulator used in the rest of this DT > then (MMC, GMAC) ? A separate fixed regulator, like most (all?) other axp209 using boards, e.g. the cubieboard has a TCS4199 regulator for this, and the banana boards use a XL8206/UP1746 for this, according to the schematics I have. Regards, Hans > > Maxime > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/