Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753953AbbHCOFY (ORCPT ); Mon, 3 Aug 2015 10:05:24 -0400 Received: from smtprelay0187.hostedemail.com ([216.40.44.187]:60182 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751982AbbHCOFW (ORCPT ); Mon, 3 Aug 2015 10:05:22 -0400 X-Session-Marker: 726F737465647440676F6F646D69732E6F7267 X-HE-Tag: act08_64754dffe3b5d X-Filterd-Recvd-Size: 1529 Date: Mon, 3 Aug 2015 10:04:49 -0400 From: Steven Rostedt To: yalin wang Cc: Minfei Huang , tj@kernel.org, mingo@redhat.com, linux-kernel@vger.kernel.org, mhuang@redhat.com Subject: Re: [PATCH] workqueue: Add the allocation flags to function schedule_on_each_cpu_gfp Message-ID: <20150803100449.52f4dadb@gandalf.local.home> In-Reply-To: <4F413CE0-A857-4350-AE04-176AA8ADC44E@gmail.com> References: <1438590425-30307-1-git-send-email-mnfhuang@gmail.com> <4F413CE0-A857-4350-AE04-176AA8ADC44E@gmail.com> X-Mailer: Claws Mail 3.11.1 (GTK+ 2.24.28; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 784 Lines: 24 On Mon, 3 Aug 2015 17:15:53 +0800 yalin wang wrote: > better to also provide a wrapper function with name schedule_on_each_cpu(), > as this function is used frequently . > > #define schedule_on_each_cpu(f) schedule_on_each_cpu_gfp(f, GFP_KERNEL) I was about to say pretty much the same thing. But please make it an inline function: static inline int schedule_on_each_cpu(work_func_t func) { return schedule_on_each_cpu_gfp(func, GFP_KERNEL); } Otherwise, NACK to the patch to the ftrace code. -- Steve -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/