Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753262AbbHCOf7 (ORCPT ); Mon, 3 Aug 2015 10:35:59 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:38323 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752538AbbHCOf6 (ORCPT ); Mon, 3 Aug 2015 10:35:58 -0400 From: Colin King To: Anil Gurumurthy , Sudarsana Kalluru , "James E.J. Bottomley" , linux-scsi@vger.kernel.org Cc: linux-kernel@vger.kernel.org Subject: [PATCH] [SCSI] bfa: fix missing { } braces Date: Mon, 3 Aug 2015 15:35:27 +0100 Message-Id: <1438612527-3707-1-git-send-email-colin.king@canonical.com> X-Mailer: git-send-email 2.5.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1797 Lines: 59 From: Colin Ian King Static analysis by smatch indicated that there was a curly braces issue: drivers/scsi/bfa/bfa_ioc.c:3668 bfa_cb_sfp_state_query() warn: curly braces intended? drivers/scsi/bfa/bfa_ioc.c:3671 bfa_cb_sfp_state_query() warn: inconsistent indenting drivers/scsi/bfa/bfa_ioc.c:3676 bfa_cb_sfp_state_query() warn: curly braces intended? The fix matches the intended logic based on the original indentation layout of the code. Signed-off-by: Colin Ian King --- drivers/scsi/bfa/bfa_ioc.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c index 315d6d6..59c3492 100644 --- a/drivers/scsi/bfa/bfa_ioc.c +++ b/drivers/scsi/bfa/bfa_ioc.c @@ -3662,7 +3662,7 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp) bfa_trc(sfp, sfp->portspeed); if (sfp->media) { bfa_sfp_media_get(sfp); - if (sfp->state_query_cbfn) + if (sfp->state_query_cbfn) { sfp->state_query_cbfn(sfp->state_query_cbarg, sfp->status); sfp->media = NULL; @@ -3670,14 +3670,16 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp) if (sfp->portspeed) { sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed); - if (sfp->state_query_cbfn) + if (sfp->state_query_cbfn) { sfp->state_query_cbfn(sfp->state_query_cbarg, sfp->status); sfp->portspeed = BFA_PORT_SPEED_UNKNOWN; + } } sfp->state_query_lock = 0; sfp->state_query_cbfn = NULL; + } } /* -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/