Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753531AbbHCPHp (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 11:07:45 -0400
Received: from casper.infradead.org ([85.118.1.10]:49147 "EHLO
	casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751637AbbHCPHn (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 11:07:43 -0400
Date: Mon, 3 Aug 2015 12:07:28 -0300
From: Arnaldo Carvalho de Melo <arnaldo.melo@gmail.com>
To: "Wangnan (F)" <wangnan0@huawei.com>
Cc: He Kuang <hekuang@huawei.com>, Li Zefan <lizefan@huawei.com>,
        ast@plumgrid.com, pi3orama@163.com, xiakaixu@huawei.com,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@kernel.org>,
        Jiri Olsa <jolsa@redhat.com>, David Ahern <dsahern@gmail.com>,
        Namhyung Kim <namhyung@kernel.org>
Subject: Re: perf eBPF patch ordering.  was: Re: perf test LLVM was: Re: [GIT
 PULL 00/39] perf tools: filtering events using eBPF programs
Message-ID: <20150803150728.GA3864@kernel.org>
References: <55A63AC4.6040701@huawei.com>
 <20150715112015.GA3868@kernel.org>
 <55A869A1.505@huawei.com>
 <CA+JHD93=ZMFP0gB1NqTXGBjTfSyYC-53Uj7r11gQJnKtQRKcDg@mail.gmail.com>
 <55AE2858.6040409@huawei.com>
 <20150721114151.GF5368@kernel.org>
 <55AF1EA5.5020500@huawei.com>
 <20150731153522.GA16700@kernel.org>
 <20150731203125.GB16700@kernel.org>
 <55BED407.9090009@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55BED407.9090009@huawei.com>
X-Url: http://acmel.wordpress.com
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1699
Lines: 49

Em Mon, Aug 03, 2015 at 10:37:59AM +0800, Wangnan (F) escreveu:
> On 2015/8/1 4:31, Arnaldo Carvalho de Melo wrote:
> >Somehow it is not calling what the changeset says it would call when passing
> >"-e foo.o", investigating...
 
> Have you tried
 
> /root/bin/perf record -e ./foo.o sleep 1

> The key is './'.

Nope, trying it now I get:

  [root@felicio ~]# perf record -e ./foo.o sleep 1
  libbpf: failed to open ./foo.o: No such file or directory
  bpf: failed to load ./foo.o
  invalid or unsupported event: './foo.o'
  Run 'perf list' for a list of valid events

   usage: perf record [<options>] [<command>]
      or: perf record [<options>] -- <command> [<options>]

    -e, --event <event>   event selector. use 'perf list' to list available events
  [root@felicio ~]#

Way too much verbosity, I think this should be just:

  [root@felicio ~]# perf record -e ./foo.o sleep 1
  perf: Failed to open ./foo.o: No such file or directory

I.e. Avoid messages coming directly from a library, as you don't know
what kind of UI tools using such library will use, it maybe GTK, for
instance, and then sending stuff to stderr or stdout is inappropriate.
 
> I have reproduced the problem. Haven't noticed that because I always use './' name.

Right, right now this is required, it should not be.
 
> Will look into it.

Thanks, I will try checkint the other patches, taking this current
limitation into account, so that I can comment on them.

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/