Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754205AbbHCPwQ (ORCPT ); Mon, 3 Aug 2015 11:52:16 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:33062 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752824AbbHCPwM (ORCPT ); Mon, 3 Aug 2015 11:52:12 -0400 Subject: Re: [PATCH] Check return code from pdc20621_i2c_read() To: Tomer Barletz References: <1438510340-21568-1-git-send-email-barletz@gmail.com> <55BDFA5C.3040506@cogentembedded.com> <55BF8BCA.40602@cogentembedded.com> Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55BF8E29.6000200@cogentembedded.com> Date: Mon, 3 Aug 2015 18:52:09 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <55BF8BCA.40602@cogentembedded.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 699 Lines: 23 On 08/03/2015 06:42 PM, Sergei Shtylyov wrote: >>> Please use pr_err() instead. And "0x%d" makes no sense at all, please >>> use "%#x" instead. >> Yeah, not sure what I was drinking before writing this 0x%d thing... >> Regarding the pr_err() - it is not used at all in this file, and >> printk() is used instead. Didn't notice before: the patch subject should start with the driver name and a colon, "sats_sx4: ". >> --Tomer MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/