Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754233AbbHCPxE (ORCPT ); Mon, 3 Aug 2015 11:53:04 -0400 Received: from devils.ext.ti.com ([198.47.26.153]:52836 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752012AbbHCPxC (ORCPT ); Mon, 3 Aug 2015 11:53:02 -0400 Message-ID: <55BF8E5B.5050408@ti.com> Date: Mon, 3 Aug 2015 11:52:59 -0400 From: Murali Karicheri Organization: Texas Instruments User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Viresh Kumar CC: , , , open list: TI NETCP ETHERNET DRIVER , Wingman Kwok , ; Illegal-Object: Syntax error in CC: address found on vger.kernel.org: CC: ; ^-missing semicolon to end mail group, extraneous tokens in mailbox, missing end of mailbox Subject: Re: [PATCH 08/15] drivers: net: Drop unlikely before IS_ERR(_OR_NULL) References: <55BB8E7B.7050307@ti.com> <20150731162018.GD899@linux> In-Reply-To: <20150731162018.GD899@linux> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 33 On 07/31/2015 12:20 PM, Viresh Kumar wrote: > On 31-07-15, 11:04, Murali Karicheri wrote: >> On 07/31/2015 04:38 AM, Viresh Kumar wrote: >>> IS_ERR(_OR_NULL) already contain an 'unlikely' compiler flag and there >>> is no need to do that again from its callers. Drop it. >>> >> >> IS_ERR_OR_NULL() is defined as >> >> static inline bool __must_check IS_ERR_OR_NULL(__force const void *ptr) >> { >> return !ptr || IS_ERR_VALUE((unsigned long)ptr); >> } >> >> So the unlikely() applies only to second part. Wouldn't that be a >> problem for optimization? > > This is what the first patch of the series does: > > http://permalink.gmane.org/gmane.linux.kernel/2009151 > Assuming the above change is merged, this patch looks good. Acked-by: Murali Karicheri -- Murali Karicheri Linux Kernel, Keystone -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/