Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754398AbbHCQZT (ORCPT ); Mon, 3 Aug 2015 12:25:19 -0400 Received: from imap.thunk.org ([74.207.234.97]:37930 "EHLO imap.thunk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753722AbbHCQZQ (ORCPT ); Mon, 3 Aug 2015 12:25:16 -0400 Date: Mon, 3 Aug 2015 12:25:11 -0400 From: "Theodore Ts'o" To: Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List Subject: Re: [REGRESSION] Re: i915 driver crashes on T540p if docking station attached Message-ID: <20150803162511.GA3563@thunk.org> Mail-Followup-To: Theodore Ts'o , Linus Torvalds , intel-gfx , DRI , Daniel Vetter , Mani Nikula , Ander Conselvan de Oliveira , Linux Kernel Mailing List References: <20150730004937.GA3133@thunk.org> <20150730013912.GA4068@thunk.org> <20150730144002.GY16722@phenom.ffwll.local> <20150730155029.GA3065@thunk.org> <20150803152729.GD24689@phenom.ffwll.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20150803152729.GD24689@phenom.ffwll.local> User-Agent: Mutt/1.5.23 (2014-03-12) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: tytso@thunk.org X-SA-Exim-Scanned: No (on imap.thunk.org); SAEximRunCond expanded to false Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 19385 Lines: 285 On Mon, Aug 03, 2015 at 05:27:29PM +0200, Daniel Vetter wrote: > > Ok I updated fixes-stuff with just 2 patches which seem to be enough to > fix it. Plus a patch to convert Linus' hack into something we can keep > plus a drive-by WARNING fix in mst that got in the way for me. > > Seems to work here in getting rid of the Oops. If this tests out for you > too I'll send a pull to Linus. I've just tried pulling in your updated fixes-stuff, and it avoids the oops and allows external the monitor to work correctly. However, I'm still seeing a large number of drm/i915 related warning messages and other kernel kvetching. Thanks!! - Ted [ 4.084198] [drm] Initialized drm 1.1.0 20060810 [ 4.129576] [drm] Memory usable by graphics device = 2048M [ 4.129616] [drm] Replacing VGA console driver [ 4.130315] Console: switching to colour dummy device 80x25 [ 4.145332] [drm] Supports vblank timestamp caching Rev 2 (21.10.2013). [ 4.145334] [drm] Driver supports precise vblank timestamp query. [ 4.146184] vgaarb: device changed decodes: PCI:0000:00:02.0,olddecodes=io+mem,decodes=io+mem:owns=io+mem [ 4.163778] usbcore: registered new interface driver btusb [ 4.170719] ------------[ cut here ]------------ [ 4.170749] WARNING: CPU: 0 PID: 463 at /usr/projects/linux/linux/drivers/gpu/drm/i915/intel_pm.c:2339 ilk_update_wm+0x71a/0xb27 [i915]() [ 4.170751] WARN_ON(!r->enable) [ 4.170752] Modules linked in: [ 4.170754] btusb btrtl btbcm btintel iwlmvm(+) bluetooth mac80211 iwlwifi snd_hda_intel i915(+) drm_kms_helper snd_hda_codec cfg80211 drm snd_hwdep lpc_ich snd_hda_core intel_gtt thinkpad_acpi tpm_tis nvram tpm intel_smartconnect uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_core sch_fq_codel kvm_intel kvm ecryptfs parport_pc ppdev lp parport autofs4 btrfs xor hid_generic usbhid hid raid6_pq microcode rtsx_pci_sdmmc ehci_pci e1000e rtsx_pci ehci_hcd xhci_pci ptp mfd_core pps_core xhci_hcd [ 4.170805] CPU: 0 PID: 463 Comm: systemd-udevd Not tainted 4.2.0-rc5-14194-g130583b #18 [ 4.170807] Hardware name: LENOVO 20BECTO1WW/20BECTO1WW, BIOS GMET59WW (2.07 ) 02/12/2014 [ 4.170809] 0000000000000009 ffff880403f0f4c8 ffffffff8161aaee 0000000000000006 [ 4.170814] ffff880403f0f518 ffff880403f0f508 ffffffff8107e5f0 0000000000000006 [ 4.170818] ffffffffc05ade43 ffff8800c8b70000 ffff8800c7f16000 ffff880405fb48b8 [ 4.170823] Call Trace: [ 4.170829] [] dump_stack+0x4c/0x65 [ 4.170833] [] warn_slowpath_common+0xa1/0xbb [ 4.170856] [] ? ilk_update_wm+0x71a/0xb27 [i915] [ 4.170859] [] warn_slowpath_fmt+0x46/0x48 [ 4.170879] [] ? ilk_compute_wm_maximums+0x43/0xa2 [i915] [ 4.170899] [] ilk_update_wm+0x71a/0xb27 [i915] [ 4.170921] [] intel_update_watermarks+0x1e/0x20 [i915] [ 4.170957] [] haswell_crtc_disable+0x270/0x2ae [i915] [ 4.170989] [] intel_crtc_control+0xa0/0xe1 [i915] [ 4.171020] [] intel_crtc_update_dpms+0x4d/0x5d [i915] [ 4.171052] [] intel_modeset_setup_hw_state+0x7b0/0xa90 [i915] [ 4.171081] [] ? hsw_write64+0xcd/0xcd [i915] [ 4.171113] [] ? ilk_fbc_disable+0x29/0x69 [i915] [ 4.171142] [] intel_modeset_init+0x130d/0x14e3 [i915] [ 4.171179] [] i915_driver_load+0xf05/0x1139 [i915] [ 4.171183] [] ? mark_held_locks+0x56/0x6c [ 4.171186] [] ? _raw_spin_unlock_irqrestore+0x3f/0x4d [ 4.171189] [] ? trace_hardirqs_on_caller+0x171/0x18d [ 4.171204] [] drm_dev_register+0x84/0xfd [drm] [ 4.171215] [] drm_get_pci_dev+0x102/0x1bc [drm] [ 4.171237] [] i915_pci_probe+0x4f/0x51 [i915] [ 4.171240] [] pci_device_probe+0x74/0xd6 [ 4.171245] [] ? driver_probe_device+0x387/0x387 [ 4.171248] [] driver_probe_device+0x15f/0x387 [ 4.171250] [] ? driver_probe_device+0x387/0x387 [ 4.171252] [] __driver_attach+0x53/0x74 [ 4.171255] [] bus_for_each_dev+0x6f/0x89 [ 4.171257] [] driver_attach+0x1e/0x20 [ 4.171260] [] bus_add_driver+0x140/0x238 [ 4.171263] [] driver_register+0x8f/0xcc [ 4.171266] [] __pci_register_driver+0x5e/0x62 [ 4.171268] [] ? 0xffffffffc069c000 [ 4.171278] [] drm_pci_init+0x58/0xda [drm] [ 4.171281] [] ? 0xffffffffc069c000 [ 4.171301] [] i915_init+0xa0/0xa8 [i915] [ 4.171303] [] ? 0xffffffffc069c000 [ 4.171307] [] do_one_initcall+0x19a/0x1af [ 4.171310] [] ? do_init_module+0x28/0x1e3 [ 4.171313] [] ? kmem_cache_alloc_trace+0xba/0xcc [ 4.171315] [] do_init_module+0x60/0x1e3 [ 4.171319] [] load_module+0x1c42/0x2059 [ 4.171324] [] SyS_finit_module+0x85/0x92 [ 4.171327] [] entry_SYSCALL_64_fastpath+0x16/0x73 [ 4.171329] ---[ end trace 7eb514b89de5fc4a ]--- [ 4.171331] ------------[ cut here ]------------ [ 4.171354] WARNING: CPU: 0 PID: 463 at /usr/projects/linux/linux/drivers/gpu/drm/i915/intel_pm.c:2339 ilk_update_wm+0x71a/0xb27 [i915]() [ 4.171355] WARN_ON(!r->enable) [ 4.171357] Modules linked in: [ 4.171358] btusb btrtl btbcm btintel iwlmvm(+) bluetooth mac80211 iwlwifi snd_hda_intel i915(+) drm_kms_helper snd_hda_codec cfg80211 drm snd_hwdep lpc_ich snd_hda_core intel_gtt thinkpad_acpi tpm_tis nvram tpm intel_smartconnect uvcvideo videobuf2_vmalloc videobuf2_memops videobuf2_core sch_fq_codel kvm_intel kvm ecryptfs parport_pc ppdev lp parport autofs4 btrfs xor hid_generic usbhid hid raid6_pq microcode rtsx_pci_sdmmc ehci_pci e1000e rtsx_pci ehci_hcd xhci_pci ptp mfd_core pps_core xhci_hcd [ 4.171404] CPU: 0 PID: 463 Comm: systemd-udevd Tainted: G W 4.2.0-rc5-14194-g130583b #18 [ 4.171406] Hardware name: LENOVO 20BECTO1WW/20BECTO1WW, BIOS GMET59WW (2.07 ) 02/12/2014 [ 4.171408] 0000000000000009 ffff880403f0f4c8 ffffffff8161aaee 0000000000000006 [ 4.171412] ffff880403f0f518 ffff880403f0f508 ffffffff8107e5f0 0000000000000006 [ 4.171417] ffffffffc05ade43 ffff8800c8b70000 ffff8800c7f15000 ffff880405fb48b8 [ 4.171421] Call Trace: [ 4.171424] [] dump_stack+0x4c/0x65 [ 4.171427] [] warn_slowpath_common+0xa1/0xbb [ 4.171449] [] ? ilk_update_wm+0x71a/0xb27 [i915] [ 4.171452] [] warn_slowpath_fmt+0x46/0x48 [ 4.171472] [] ? ilk_compute_wm_maximums+0x43/0xa2 [i915] [ 4.171491] [] ilk_update_wm+0x71a/0xb27 [i915] [ 4.171513] [] intel_update_watermarks+0x1e/0x20 [i915] [ 4.171546] [] haswell_crtc_disable+0x270/0x2ae [i915] [ 4.171579] [] intel_crtc_control+0xa0/0xe1 [i915] [ 4.171610] [] intel_crtc_update_dpms+0x4d/0x5d [i915] [ 4.171641] [] intel_modeset_setup_hw_state+0x7b0/0xa90 [i915] [ 4.171671] [] ? hsw_write64+0xcd/0xcd [i915] [ 4.171702] [] ? ilk_fbc_disable+0x29/0x69 [i915] [ 4.171733] [] intel_modeset_init+0x130d/0x14e3 [i915] [ 4.171770] [] i915_driver_load+0xf05/0x1139 [i915] [ 4.171773] [] ? mark_held_locks+0x56/0x6c [ 4.171776] [] ? _raw_spin_unlock_irqrestore+0x3f/0x4d [ 4.171779] [] ? trace_hardirqs_on_caller+0x171/0x18d [ 4.171791] [] drm_dev_register+0x84/0xfd [drm] [ 4.171802] [] drm_get_pci_dev+0x102/0x1bc [drm] [ 4.171825] [] i915_pci_probe+0x4f/0x51 [i915] [ 4.171828] [] pci_device_probe+0x74/0xd6 [ 4.171831] [] ? driver_probe_device+0x387/0x387 [ 4.171833] [] driver_probe_device+0x15f/0x387 [ 4.171836] [] ? driver_probe_device+0x387/0x387 [ 4.171838] [] __driver_attach+0x53/0x74 [ 4.171841] [] bus_for_each_dev+0x6f/0x89 [ 4.171844] [] driver_attach+0x1e/0x20 [ 4.171846] [] bus_add_driver+0x140/0x238 [ 4.171849] [] driver_register+0x8f/0xcc [ 4.171852] [] __pci_register_driver+0x5e/0x62 [ 4.171854] [] ? 0xffffffffc069c000 [ 4.171866] [] drm_pci_init+0x58/0xda [drm] [ 4.171868] [] ? 0xffffffffc069c000 [ 4.171890] [] i915_init+0xa0/0xa8 [i915] [ 4.171893] [] ? 0xffffffffc069c000 [ 4.171896] [] do_one_initcall+0x19a/0x1af [ 4.171898] [] ? do_init_module+0x28/0x1e3 [ 4.171901] [] ? kmem_cache_alloc_trace+0xba/0xcc [ 4.171904] [] do_init_module+0x60/0x1e3 [ 4.171907] [] load_module+0x1c42/0x2059 [ 4.171911] [] SyS_finit_module+0x85/0x92 [ 4.171914] [] entry_SYSCALL_64_fastpath+0x16/0x73 [ 4.171916] ---[ end trace 7eb514b89de5fc4b ]--- [ 4.176978] Bluetooth: hci0: read Intel version: 370710018002030d48 [ 4.176981] Bluetooth: hci0: Intel device is already patched. patch num: 48 [ 4.181839] ====================================================== [ 4.181844] [ INFO: possible circular locking dependency detected ] [ 4.181849] 4.2.0-rc5-14194-g130583b #18 Tainted: G W [ 4.181854] ------------------------------------------------------- [ 4.181859] systemd-udevd/463 is trying to acquire lock: [ 4.181864] (init_mutex){+.+.+.}, at: [] acpi_video_get_backlight_type+0x17/0x164 [ 4.181878] but task is already holding lock: [ 4.181883] (&(&backlight_notifier)->rwsem){++++..}, at: [] __blocking_notifier_call_chain+0x37/0x69 [ 4.181895] which lock already depends on the new lock. [ 4.181902] the existing dependency chain (in reverse order) is: [ 4.181912] -> #1 (&(&backlight_notifier)->rwsem){++++..}: [ 4.181923] [] lock_acquire+0x104/0x18b [ 4.181932] [] down_write+0x46/0x8a [ 4.181942] [] blocking_notifier_chain_register+0x36/0x57 [ 4.181953] [] backlight_register_notifier+0x18/0x1a [ 4.181962] [] acpi_video_get_backlight_type+0xfa/0x164 [ 4.181973] [] 0xffffffffc03d2e45 [ 4.181981] [] 0xffffffffc03d38a8 [ 4.181988] [] do_one_initcall+0x19a/0x1af [ 4.181997] [] do_init_module+0x60/0x1e3 [ 4.182006] [] load_module+0x1c42/0x2059 [ 4.182015] [] SyS_finit_module+0x85/0x92 [ 4.182023] [] entry_SYSCALL_64_fastpath+0x16/0x73 [ 4.182031] -> #0 (init_mutex){+.+.+.}: [ 4.182042] [] __lock_acquire+0xc55/0xf54 [ 4.182050] [] lock_acquire+0x104/0x18b [ 4.182058] [] mutex_lock_nested+0x70/0x391 [ 4.182066] [] acpi_video_get_backlight_type+0x17/0x164 [ 4.182077] [] acpi_video_backlight_notify+0x19/0x2f [ 4.182086] [] notifier_call_chain+0x4c/0x71 [ 4.182094] [] __blocking_notifier_call_chain+0x50/0x69 [ 4.182105] [] blocking_notifier_call_chain+0x14/0x16 [ 4.182116] [] backlight_device_register+0x1df/0x1f1 [ 4.182125] [] intel_backlight_register+0xf0/0x157 [i915] [ 4.182174] [] intel_modeset_gem_init+0x158/0x164 [i915] [ 4.182214] [] i915_driver_load+0xf1c/0x1139 [i915] [ 4.182253] [] drm_dev_register+0x84/0xfd [drm] [ 4.182271] [] drm_get_pci_dev+0x102/0x1bc [drm] [ 4.182287] [] i915_pci_probe+0x4f/0x51 [i915] [ 4.182314] [] pci_device_probe+0x74/0xd6 [ 4.182322] [] driver_probe_device+0x15f/0x387 [ 4.182331] [] __driver_attach+0x53/0x74 [ 4.182339] [] bus_for_each_dev+0x6f/0x89 [ 4.182347] [] driver_attach+0x1e/0x20 [ 4.182355] [] bus_add_driver+0x140/0x238 [ 4.182363] [] driver_register+0x8f/0xcc [ 4.182371] [] __pci_register_driver+0x5e/0x62 [ 4.182379] [] drm_pci_init+0x58/0xda [drm] [ 4.182396] [] i915_init+0xa0/0xa8 [i915] [ 4.182423] [] do_one_initcall+0x19a/0x1af [ 4.182432] [] do_init_module+0x60/0x1e3 [ 4.182440] [] load_module+0x1c42/0x2059 [ 4.182448] [] SyS_finit_module+0x85/0x92 [ 4.182456] [] entry_SYSCALL_64_fastpath+0x16/0x73 [ 4.182465] other info that might help us debug this: [ 4.182477] Possible unsafe locking scenario: [ 4.182486] CPU0 CPU1 [ 4.182491] ---- ---- [ 4.182497] lock(&(&backlight_notifier)->rwsem); [ 4.182504] lock(init_mutex); [ 4.182512] lock(&(&backlight_notifier)->rwsem); [ 4.182522] lock(init_mutex); [ 4.182528] *** DEADLOCK *** [ 4.182540] 4 locks held by systemd-udevd/463: [ 4.182546] #0: (&dev->mutex){......}, at: [] device_lock+0xf/0x11 [ 4.182560] #1: (&dev->mutex){......}, at: [] device_lock+0xf/0x11 [ 4.182574] #2: (drm_global_mutex){+.+.+.}, at: [] drm_dev_register+0x24/0xfd [drm] [ 4.182596] #3: (&(&backlight_notifier)->rwsem){++++..}, at: [] __blocking_notifier_call_chain+0x37/0x69 [ 4.182612] stack backtrace: [ 4.182622] CPU: 0 PID: 463 Comm: systemd-udevd Tainted: G W 4.2.0-rc5-14194-g130583b #18 [ 4.182632] Hardware name: LENOVO 20BECTO1WW/20BECTO1WW, BIOS GMET59WW (2.07 ) 02/12/2014 [ 4.182642] ffffffff8280b780 ffff880403f0f5d8 ffffffff8161aaee 0000000000000006 [ 4.182654] ffffffff8280b780 ffff880403f0f628 ffffffff810b9b51 ffffffff82265780 [ 4.182667] ffff880403de0000 0000000000000004 ffff880403de0880 0000000000000004 [ 4.182679] Call Trace: [ 4.182685] [] dump_stack+0x4c/0x65 [ 4.182693] [] print_circular_bug+0x1f8/0x209 [ 4.182701] [] __lock_acquire+0xc55/0xf54 [ 4.182710] [] lock_acquire+0x104/0x18b [ 4.182717] [] ? acpi_video_get_backlight_type+0x17/0x164 [ 4.182726] [] mutex_lock_nested+0x70/0x391 [ 4.182734] [] ? acpi_video_get_backlight_type+0x17/0x164 [ 4.182742] [] ? acpi_video_get_backlight_type+0x17/0x164 [ 4.182750] [] acpi_video_get_backlight_type+0x17/0x164 [ 4.182759] [] acpi_video_backlight_notify+0x19/0x2f [ 4.182766] [] notifier_call_chain+0x4c/0x71 [ 4.182774] [] __blocking_notifier_call_chain+0x50/0x69 [ 4.182782] [] blocking_notifier_call_chain+0x14/0x16 [ 4.182790] [] backlight_device_register+0x1df/0x1f1 [ 4.182833] [] intel_backlight_register+0xf0/0x157 [i915] [ 4.182872] [] intel_modeset_gem_init+0x158/0x164 [i915] [ 4.182915] [] i915_driver_load+0xf1c/0x1139 [i915] [ 4.182924] [] ? mark_held_locks+0x56/0x6c [ 4.182932] [] ? _raw_spin_unlock_irqrestore+0x3f/0x4d [ 4.182940] [] ? trace_hardirqs_on_caller+0x171/0x18d [ 4.182956] [] drm_dev_register+0x84/0xfd [drm] [ 4.182972] [] drm_get_pci_dev+0x102/0x1bc [drm] [ 4.182998] [] i915_pci_probe+0x4f/0x51 [i915] [ 4.183006] [] pci_device_probe+0x74/0xd6 [ 4.183014] [] ? driver_probe_device+0x387/0x387 [ 4.183021] [] driver_probe_device+0x15f/0x387 [ 4.183029] [] ? driver_probe_device+0x387/0x387 [ 4.183036] [] __driver_attach+0x53/0x74 [ 4.183043] [] bus_for_each_dev+0x6f/0x89 [ 4.183050] [] driver_attach+0x1e/0x20 [ 4.183058] [] bus_add_driver+0x140/0x238 [ 4.183065] [] driver_register+0x8f/0xcc [ 4.183073] [] __pci_register_driver+0x5e/0x62 [ 4.183080] [] ? 0xffffffffc069c000 [ 4.183095] [] drm_pci_init+0x58/0xda [drm] [ 4.183102] [] ? 0xffffffffc069c000 [ 4.183126] [] i915_init+0xa0/0xa8 [i915] [ 4.183132] [] ? 0xffffffffc069c000 [ 4.183139] [] do_one_initcall+0x19a/0x1af [ 4.183146] [] ? do_init_module+0x28/0x1e3 [ 4.183153] [] ? kmem_cache_alloc_trace+0xba/0xcc [ 4.183161] [] do_init_module+0x60/0x1e3 [ 4.183169] [] load_module+0x1c42/0x2059 [ 4.183178] [] SyS_finit_module+0x85/0x92 [ 4.183185] [] entry_SYSCALL_64_fastpath+0x16/0x73 [ 4.186598] ACPI: Video Device [VID] (multi-head: yes rom: no post: no) [ 4.191522] snd_hda_intel 0000:00:03.0: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) [ 4.191536] [drm] Initialized i915 1.6.0 20150522 for 0000:00:02.0 on minor 0 [ 4.191691] i801_smbus 0000:00:1f.3: SMBus using PCI interrupt [ 4.248792] [drm] GMBUS [i915 gmbus dpb] timed out, falling back to bit banging on pin 5 [ 4.322899] fbcon: inteldrmfb (fb0) is primary device [ 5.440946] Console: switching to colour frame buffer device 360x101 [ 5.452747] i915 0000:00:02.0: fb0: inteldrmfb frame buffer device [ 5.452767] i915 0000:00:02.0: registered panic notifier -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/