Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754306AbbHCRzc (ORCPT ); Mon, 3 Aug 2015 13:55:32 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:53469 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752323AbbHCRzb (ORCPT ); Mon, 3 Aug 2015 13:55:31 -0400 Message-ID: <55BFAB11.7080600@codeaurora.org> Date: Mon, 03 Aug 2015 10:55:29 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Pawel Moll CC: Mike Turquette , "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" , Linus Walleij , Sudeep Holla Subject: Re: [PATCH 1/3] clk: versatile: Switch to assigned clock parents References: <55BBB2FC.9030102@codeaurora.org> <1438386285-5070-1-git-send-email-sboyd@codeaurora.org> <1438386285-5070-2-git-send-email-sboyd@codeaurora.org> <1438610480.2142.14.camel@arm.com> In-Reply-To: <1438610480.2142.14.camel@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1969 Lines: 47 On 08/03/2015 07:01 AM, Pawel Moll wrote: > On Sat, 2015-08-01 at 00:44 +0100, Stephen Boyd wrote: >> @@ -179,6 +124,15 @@ static void __init clk_sp810_of_setup(struct device_node *node) >> sp810->timerclken[i].channel = i; >> sp810->timerclken[i].hw.init = &init; >> >> + /* >> + * If DT isn't setting the parent, force it to be >> + * the 1 MHz clock without going through the framework. >> + * We do this before clk_register() so that it can determine >> + * the parent and setup the tree properly. >> + */ >> + if (deprecated) >> + init.ops->set_parent(&sp810->timerclken[i].hw, 1); >> + >> sp810->timerclken[i].clk = clk_register(NULL, >> &sp810->timerclken[i].hw); >> WARN_ON(IS_ERR(sp810->timerclken[i].clk)); > So that's one thing I've got a (small) problem here... > > The above change assumes that SP810 always have 32kHz clock on input 0 > and 1MHz clock on input 1. Yes, this is how it made on VExpress, but it > doesn't have to be the case. The magic picking up the faster clock was > added to handle all possible cases. > > The bottom line is: if all we care is VExpress than it works, but it's > still a hack. Personally I don't like it, however I won't nak the patch > because of this. > All current dts files in the kernel tree have 1MHz on input 1, so we make this change here to set the parent to input 1 if there isn't an assigned-clock-parents property. Presumably new dts files should have the new property so that things work properly. I tried to find the binding document, but it doesn't look to exist, so I didn't have anything to update. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/