Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932129AbbHCTTP (ORCPT ); Mon, 3 Aug 2015 15:19:15 -0400 Received: from mail-la0-f44.google.com ([209.85.215.44]:35085 "EHLO mail-la0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754803AbbHCTTN (ORCPT ); Mon, 3 Aug 2015 15:19:13 -0400 Subject: Re: [PATCH] sata_sx4: Check return code from pdc20621_i2c_read() To: Tomer Barletz References: <55BF8E29.6000200@cogentembedded.com> <1438627595-17126-1-git-send-email-barletz@gmail.com> <55BFB87C.1010405@cogentembedded.com> Cc: tj@kernel.org, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org From: Sergei Shtylyov Organization: Cogent Embedded Message-ID: <55BFBEAE.6030707@cogentembedded.com> Date: Mon, 3 Aug 2015 22:19:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 754 Lines: 22 On 08/03/2015 10:04 PM, Tomer Barletz wrote: Please don't top-post. > I see how it makes sense to add a tab to align with the previous line > of code, as it will always look similar in all editors, no matter how > their tab character is set up to be. > However, adding more tabs will just mess up editors that are not set > up with 8-space width tabs. > Is this a bug in checkpatch.pl, or are we saying everyone should have > their editor set to 8-spaces width tabs? The latter. :-) MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/