Date: Mon, 3 Aug 2015 15:28:10 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        mingo@kernel.org, jasonbaron0@gmail.com, bp@alien8.de,
        luto@amacapital.net, tglx@linutronix.de, will.deacon@arm.com,
        liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org,
        ddaney@caviumnetworks.com, benh@kernel.crashing.org,
        michael@ellerman.id.au, heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface
Message-ID: <20150803152810.5a7bcf06@gandalf.local.home>
In-Reply-To: <20150803191816.GC25159@twins.programming.kicks-ass.net>
References: <20150728132055.203176565@infradead.org>
	<20150728132313.164884020@infradead.org>
	<55B87E7A.2070509@suse.cz>
	<20150729084906.GH19282@twins.programming.kicks-ass.net>
	<20150803150359.0e76b576@gandalf.local.home>
	<20150803191816.GC25159@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1477
Lines: 42

On Mon, 3 Aug 2015 21:18:16 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Aug 03, 2015 at 03:03:59PM -0400, Steven Rostedt wrote:
> 
> > I wonder if static_branch_set_false(&blah) would be a better name to
> > understand. What does "disable" / "enable" mean?
> 
> "make false" / "make true" ? Check a local dictionary.
> 
> http://lmgtfy.com/?q=enable

I know the definition on enable :-p

> 
> "2. computing: make (a device or system) operational; active"
> 
> A value can be true/false, an action that makes true/false is
> enable/disable.

enable is more "activate" and disable is more "deactivate" not "make
true" and "make false". It's subtle, but there is a difference. Try
switching it around in other contexts. One could "disable networking"
but saying "make networking false" doesn't make sense.

Technically, one can think: "activate the branch", but we are
activating not the branch, but the jump label itself. It's not as clear
as setting it to "true" or "false".

What the static_branch does is already confusing enough, we should try
to use the terminology that is as clear as possible.

"set_true" is more understandable than "enable" when one can question,
what exactly are we "enabling"?

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/