Message-ID: <1438633423.2097.33.camel@freescale.com>
Subject: Re: [PATCH v5] powerpc/rcpm: add RCPM driver
From: Scott Wood <scottwood@freescale.com>
To: Chenhui Zhao <chenhui.zhao@freescale.com>
CC: <Yuantian.Tang@freescale.com>, <b07421@freescale.com>,
        <linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>,
        <devicetree@vger.kernel.org>
Date: Mon, 3 Aug 2015 15:23:43 -0500
In-Reply-To: <1438600486.7515.1@remotesmtp.freescale.net>
References: <1435304656-34505-1-git-send-email-Yuantian.Tang@freescale.com>
	 <1438389906.19345.101.camel@freescale.com>
	 <1438600486.7515.1@remotesmtp.freescale.net>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2015 20:23:50.1532
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1474
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1171
Lines: 35

On Mon, 2015-08-03 at 19:14 +0800, Chenhui Zhao wrote:
> On Sat, Aug 1, 2015 at 8:45 AM, Scott Wood <scottwood@freescale.com> 
> wrote:
> > On Fri, 2015-06-26 at 15:44 +0800,  Yuantian.Tang@freescale.comwrote:
> > >  +static void rcpm_v1_set_ip_power(bool enable, u32 *mask)
> > >  +{
> > >  +     if (enable)
> > >  +             setbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > >  +     else
> > >  +             clrbits32(&rcpm_v1_regs->ippdexpcr, *mask);
> > >  +}
> > >  +
> > >  +static void rcpm_v2_set_ip_power(bool enable, u32 *mask)
> > >  +{
> > >  +     if (enable)
> > >  +             setbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > >  +     else
> > >  +             clrbits32(&rcpm_v2_regs->ippdexpcr[0], *mask);
> > >  +}
> > 
> > Why do these take "u32 *mask" instead of "u32 mask"?
> > 
> > -Scott
> 
> I think it can be used in the case where there are several mask values.

When would that be?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/