Message-ID: <1438633568.2097.35.camel@freescale.com>
Subject: Re: [PATCH 1/3] Powerpc: mpc85xx: refactor the PM operations
From: Scott Wood <scottwood@freescale.com>
To: Chenhui Zhao <chenhui.zhao@freescale.com>
CC: <b29983@freescale.com>, <b07421@freescale.com>,
        <linux-kernel@vger.kernel.org>,
        Tang Yuantian <Yuantian.Tang@freescale.com>,
        Tang Yuantian <Yuantian.Tang@feescale.com>
Date: Mon, 3 Aug 2015 15:26:08 -0500
In-Reply-To: <1438601578.7515.2@remotesmtp.freescale.net>
References: <1438334444-31919-1-git-send-email-b29983@freescale.com>
	 <1438387178.19345.77.camel@freescale.com>
	 <1438601578.7515.2@remotesmtp.freescale.net>
Content-Type: text/plain; charset="UTF-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2015 20:26:17.7702
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1476
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2030
Lines: 57

On Mon, 2015-08-03 at 19:32 +0800, Chenhui Zhao wrote:
> > 

> On Sat, Aug 1, 2015 at 7:59 AM, Scott Wood <scottwood@freescale.com> 
> wrote:

> >
> > Could you explain irq_mask()?  Why would there still be IRQs destined 
> > for
> > this CPU at this point?
> 
> This function just masks irq by setting the registers in RCPM (for 
> example, RCPM_CPMIMR, RCPM_CPMCIMR). Actually, all irqs to this CPU 
> have been migrated to other CPUs.

So why do we need to set those bits in RCPM?  Is it just caution?

> > @@ -431,21 +415,9 @@ void __init mpc85xx_smp_init(void)
> > >                smp_85xx_ops.probe = NULL;
> > >        }
> > > 
> > >  -     np = of_find_matching_node(NULL, mpc85xx_smp_guts_ids);
> > >  -     if (np) {
> > >  -             guts = of_iomap(np, 0);
> > >  -             of_node_put(np);
> > >  -             if (!guts) {
> > >  -                     pr_err("%s: Could not map guts node 
> > > address\n",
> > >  -                                                             
> > > __func__);
> > >  -                     return;
> > >  -             }
> > >  -             smp_85xx_ops.give_timebase = mpc85xx_give_timebase;
> > >  -             smp_85xx_ops.take_timebase = mpc85xx_take_timebase;
> > >   #ifdef CONFIG_HOTPLUG_CPU
> > >  -             ppc_md.cpu_die = smp_85xx_mach_cpu_die;
> > >  +     ppc_md.cpu_die = qoriq_cpu_dying;
> > >   #endif
> > 
> > Shouldn't you make sure there's a valid qoriq_pm_ops before setting
> > cpu_die()?  Or make sure that qoriq_cpu_dying() works regardless.
> > 
> > -Scott
> 
> This patch is just for e500v2. The following patches will handle the 
> case of e500mc, e5500 and e6500.

What stops a user from trying to use cpu hotplug on unsupported cpus, or in a 
virtualized environment, and crashing here?

-Scott

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/