Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755625AbbHCVLe (ORCPT ); Mon, 3 Aug 2015 17:11:34 -0400 Received: from bear.ext.ti.com ([192.94.94.41]:56243 "EHLO bear.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755198AbbHCVL3 (ORCPT ); Mon, 3 Aug 2015 17:11:29 -0400 From: Andreas Dannenberg To: Sebastian Reichel , Dmitry Eremin-Solenikov , David Woodhouse CC: , , Andreas Dannenberg Subject: [PATCH] power: bq24190_charger: Fix charge type sysfs property Date: Mon, 3 Aug 2015 16:10:34 -0500 Message-ID: <1438636234-20321-1-git-send-email-dannenberg@ti.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1820 Lines: 45 Access to the BQ24190's configurable charge type property (none, trickle, fast) is being masked by an incorrect power_supply_property entry. After applying this patch a new 'charge_type' property will appear in the bq24190-charger sysfs folder backed up by getters/setters already present in the driver. Signed-off-by: Andreas Dannenberg --- The current driver incorrectly tries to declare the charge type property using POWER_SUPPLY_PROP_TYPE which is the wrong declaration for this (actually POWER_SUPPLY_PROP_TYPE itself has been superseeded by power_supply.type and isn't even used anymore as part of the power supply property declarations). After implementing the fix tested this aspect of the driver using an actual BQ24190 device and could witness the impact the change of charge type has on the battery (writing '1' to the new sysfs property means charging off, '2' will do trickle charging, and '3' will result in fast charging). drivers/power/bq24190_charger.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/power/bq24190_charger.c b/drivers/power/bq24190_charger.c index 052db78..40ae47c 100644 --- a/drivers/power/bq24190_charger.c +++ b/drivers/power/bq24190_charger.c @@ -902,7 +902,7 @@ static int bq24190_charger_property_is_writeable(struct power_supply *psy, } static enum power_supply_property bq24190_charger_properties[] = { - POWER_SUPPLY_PROP_TYPE, + POWER_SUPPLY_PROP_CHARGE_TYPE, POWER_SUPPLY_PROP_HEALTH, POWER_SUPPLY_PROP_ONLINE, POWER_SUPPLY_PROP_CONSTANT_CHARGE_CURRENT, -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/