Date: Mon, 3 Aug 2015 17:38:20 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: "Kirill A. Shutemov" <kirill@shutemov.name>
Cc: Vlastimil Babka <vbabka@suse.cz>, Viresh Kumar <viresh.kumar@linaro.org>,
        akpm@linux-foundation.org, linaro-kernel@lists.linaro.org,
        linux-kernel@vger.kernel.org,
        Hans Ulli Kroll <ulli.kroll@googlemail.com>,
        Alexandre Belloni <alexandre.belloni@free-electrons.com>,
        Oleg Drokin <oleg.drokin@intel.com>,
        Andreas Dilger <andreas.dilger@intel.com>
Subject: Re: [PATCH 00/15] trivial: Drop unlikely before IS_ERR(_OR_NULL)
Message-ID: <20150803173820.5a6111ea@gandalf.local.home>
In-Reply-To: <20150731102310.GA31850@node.dhcp.inet.fi>
References: <cover.1438331416.git.viresh.kumar@linaro.org>
	<55BB42B5.5070409@suse.cz>
	<20150731102310.GA31850@node.dhcp.inet.fi>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1294
Lines: 36

On Fri, 31 Jul 2015 13:23:10 +0300
"Kirill A. Shutemov" <kirill@shutemov.name> wrote:

> On Fri, Jul 31, 2015 at 11:41:09AM +0200, Vlastimil Babka wrote:
> > On 07/31/2015 10:38 AM, Viresh Kumar wrote:
> > >Hi,
> > >
> > >This cleans up the usage of IS_ERR(_OR_NULL)(), where the callers have
> > >added additional unlikely compiler flag to them. It also fixes the
> > >definition of IS_ERR_OR_NULL(), to use unlikely for all checks it does.
> > 
> > [+CC Steven Rostedt]
> > 
> > Any idea what the compiler does in the case of
> > "if (likely(IS_ERR(...)))"? There are apparently such cases in the source.
> 
> We have two cases in code:
> 
> drivers/rtc/rtc-gemini.c:       if (likely(IS_ERR(rtc->rtc_dev)))
> drivers/staging/lustre/lustre/obdclass/lu_object.c:     if (likely(IS_ERR(shadow) && PTR_ERR(shadow) == -ENOENT)) {
> 
> The first one is mistake, I think. Or do we expect rtc_device_register()
> to fail?
> 
> The second is redundant. "if (PTR_ERR(shadow) == -ENOENT)" should do the
> job.
> 

Yep, those look like bugs to me.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/