Date: Mon, 3 Aug 2015 17:57:57 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Vlastimil Babka <vbabka@suse.cz>, linux-kernel@vger.kernel.org,
        mingo@kernel.org, jasonbaron0@gmail.com, bp@alien8.de,
        luto@amacapital.net, tglx@linutronix.de, will.deacon@arm.com,
        liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org,
        ddaney@caviumnetworks.com, benh@kernel.crashing.org,
        michael@ellerman.id.au, heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface
Message-ID: <20150803175757.2adf3275@gandalf.local.home>
In-Reply-To: <20150803200002.GE25159@twins.programming.kicks-ass.net>
References: <20150728132055.203176565@infradead.org>
	<20150728132313.164884020@infradead.org>
	<55B87E7A.2070509@suse.cz>
	<20150729084906.GH19282@twins.programming.kicks-ass.net>
	<20150803150359.0e76b576@gandalf.local.home>
	<20150803191816.GC25159@twins.programming.kicks-ass.net>
	<20150803152810.5a7bcf06@gandalf.local.home>
	<20150803200002.GE25159@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1001
Lines: 34

On Mon, 3 Aug 2015 22:00:02 +0200
Peter Zijlstra <peterz@infradead.org> wrote:

> On Mon, Aug 03, 2015 at 03:28:10PM -0400, Steven Rostedt wrote:
> > Technically, one can think: "activate the branch", but we are
> > activating not the branch, but the jump label itself.
> 
> No you are enabling the branch, you're making the branch body active.

By making the statement "true".

Otherwise we could just have:

	static_branch_likely(&blah) {
		[..]
	}

And remove the "if".

Then it would make sense to enable or disable it.

> 
> There is no enable/disable/true/false for the jump label, only NOP or
> JUMP, and either can result in an active branch body.

That's implementation details, not a general concept that users will
need to know about.

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/