Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755739AbbHCWqh (ORCPT ); Mon, 3 Aug 2015 18:46:37 -0400 Received: from shards.monkeyblade.net ([149.20.54.216]:45380 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752334AbbHCWqg (ORCPT ); Mon, 3 Aug 2015 18:46:36 -0400 Date: Mon, 03 Aug 2015 15:46:35 -0700 (PDT) Message-Id: <20150803.154635.964762632357776736.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, linux@roeck-us.net, andrew@lunn.ch, f.fainelli@gmail.com Subject: Re: [PATCH] net: dsa: mv88e6xxx: call _mv88e6xxx_stats_wait with SMI lock held From: David Miller In-Reply-To: <1438607864-17829-1-git-send-email-vivien.didelot@savoirfairelinux.com> References: <1438607864-17829-1-git-send-email-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.6 on Emacs 24.5 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 03 Aug 2015 15:46:35 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 647 Lines: 16 From: Vivien Didelot Date: Mon, 3 Aug 2015 09:17:44 -0400 > At switch setup, _mv88e6xxx_stats_wait was called without holding the > SMI mutex. Fix this by requesting the lock for this call. > > Also, return the _mv88e6xxx_stats_wait code, since it may fail. > > Signed-off-by: Vivien Didelot Applied to net-next, thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/