Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932104AbbHCXAg (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 19:00:36 -0400
Received: from mx2.suse.de ([195.135.220.15]:58435 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751327AbbHCXAf (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 19:00:35 -0400
Subject: Re: [PATCH 0/4] loop: enable different physical blocksizes
To: Ming Lei <tom.leiming@gmail.com>, Hannes Reinecke <hare@suse.de>
References: <1437118027-94602-1-git-send-email-hare@suse.de>
 <CACVXFVP9T=JjQdf=DJ3vvkoOtByXka=zkuGkZi74-s2jmyG=gQ@mail.gmail.com>
Cc: Jens Axboe <axboe@fb.com>, Christoph Hellwig <hch@lst.de>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
From: Alexander Graf <agraf@suse.de>
Message-ID: <55BFF28B.8000308@suse.de>
Date: Tue, 4 Aug 2015 00:00:27 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:38.0)
 Gecko/20100101 Thunderbird/38.1.0
MIME-Version: 1.0
In-Reply-To: <CACVXFVP9T=JjQdf=DJ3vvkoOtByXka=zkuGkZi74-s2jmyG=gQ@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1772
Lines: 46



On 27.07.15 11:40, Ming Lei wrote:
> On Fri, Jul 17, 2015 at 3:27 AM, Hannes Reinecke <hare@suse.de> wrote:
>> Currently the loop driver just simulates 512-byte blocks. When
>> creating images for virtual machines it might be required to use
>> a different physical blocksize (eg 4k for S/390 DASD).
> 
> Looks 'qemu-img create' doesn't have parameter of block size,
> so could you share your use case? And I am just curious why
> 512-byte can't work for this case.

If you only want to access the virtual disk inside of QEMU you're all
good. However, if you want to directly run mkfs or fdasd on a loopback
device, then you need to expose 4k blocksize to the tools or they end up
creating a different on-disk format (if they work at all).

So the easiest case where things go wrong is

  $ qemu-img create test.img 1G
  $ losetup /dev/loop0 test.img
  $ mkfs.ext4 /dev/loop0
  $ qemu <with lots of options to pass the disk as 4k disk>

because the guest thinks the disk is formatted with 4k sector size,
while mkfs thought it's formatted with 512 byte sector size.

With this patch you can do

  $ qemu-img create test.img 1G
  $ losetup -B 4096 /dev/loop0 test.img
  $ mkfs.ext4 /dev/loop0
  $ qemu <with lots of options to pass the disk as 4k disk>

and it will work because both views of the world are identical. The same
applies for images you pull from a disk. So if you have a real 4k
logical sector size disk and you dd an image from it, you won't be able
to loop mount it today. With this patch set, you can.


Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/