Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751834AbbHDBDQ (ORCPT ); Mon, 3 Aug 2015 21:03:16 -0400 Received: from mgwym03.jp.fujitsu.com ([211.128.242.42]:36958 "EHLO mgwym03.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751221AbbHDBDP (ORCPT ); Mon, 3 Aug 2015 21:03:15 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v2.2.3 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20140219-2 Subject: Re: [PATCH] x86: Clean up files of Intel Processor Trace To: , References: <1438589411-6104-1-git-send-email-indou.takao@jp.fujitsu.com> <874mkg7nhq.fsf@ashishki-desk.ger.corp.intel.com> <20150803090807.GG25159@twins.programming.kicks-ass.net> From: Takao Indoh CC: , , , , , Message-ID: <55C00F1F.9040007@jp.fujitsu.com> Date: Tue, 4 Aug 2015 10:02:23 +0900 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit X-SecurityPolicyCheck-GC: OK by FENCE-Mail X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1320 Lines: 38 On 2015/08/03 18:44, Alexander Shishkin wrote: > On 3 August 2015 at 12:08, Peter Zijlstra wrote: >> On Mon, Aug 03, 2015 at 12:03:13PM +0300, Alexander Shishkin wrote: >>> Takao Indoh writes: >> >>> Even though TOPA_SHIFT happens to be the same as PAGE_SHIFT, it is a >>> property of a separate hardware block, not mmu. PAGE_SHIFT is 12, but >>> 12 is not always PAGE_SHIFT. >> >> PAGE_SHIFT is _always_ 12 on x86. Changing that will require changing >> the page table format, a rather unlikely thing to go happen. > > Of course. Yet that doesn't justify turning every 12 into PAGE_SHIFT > is what I'm saying. > > Oh, look, it's PAGE_SHIFT o'clock on x86, time for lunch. :) I thought the base address of output region is page aligned. I took a look at Intel SDM again, it just says the base address is 4K-aligned physical address, does not mention page size. So, logically TOPA_SHIFT and PAGE_SHIFT are different things and I'll remove this change in next version. Thanks, Takao Indoh > > Regards, > -- > Alex > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/