Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753333AbbHDBq2 (ORCPT ); Mon, 3 Aug 2015 21:46:28 -0400 Received: from mail-qg0-f47.google.com ([209.85.192.47]:32877 "EHLO mail-qg0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235AbbHDBq0 (ORCPT ); Mon, 3 Aug 2015 21:46:26 -0400 Message-ID: <55C0196C.7090308@hurleysoftware.com> Date: Mon, 03 Aug 2015 21:46:20 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Maciej S. Szmigiero" CC: linux-serial@vger.kernel.org, Greg Kroah-Hartman , Jiri Slaby , linux-kernel Subject: Re: [PATCH] serial: don't announce CIR serial ports References: <55BE8725.6090303@maciej.szmigiero.name> In-Reply-To: <55BE8725.6090303@maciej.szmigiero.name> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1554 Lines: 44 Hi Maciej, On 08/02/2015 05:09 PM, Maciej S. Szmigiero wrote: > CIR type serial ports aren't real serial ports. > This is just a way to prevent legacy serial driver > from probing and eventually binding some resources > so don't announce them like normal serial ports. I'd like to keep some form of reporting so that we know the port was properly probed; what about extending uart_report_port() to including CIR + disabled status? Secondly, good catch! Because we should not be trying to register a console on this port, nor driving modem signals. So maybe an early exit after uart_report_port? Regards, Peter Hurley > Signed-off-by: Maciej Szmigiero > --- > drivers/tty/serial/serial_core.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c > index f368520..99f944d 100644 > --- a/drivers/tty/serial/serial_core.c > +++ b/drivers/tty/serial/serial_core.c > @@ -2237,7 +2237,7 @@ uart_configure_port(struct uart_driver *drv, struct uart_state *state, > port->ops->config_port(port, flags); > } > > - if (port->type != PORT_UNKNOWN) { > + if (port->type != PORT_UNKNOWN && port->type != PORT_8250_CIR) { > unsigned long flags; > > uart_report_port(drv, port); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/