Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754595AbbHDC1v (ORCPT <rfc822;w@1wt.eu>);
	Mon, 3 Aug 2015 22:27:51 -0400
Received: from smtprelay0027.hostedemail.com ([216.40.44.27]:33713 "EHLO
	smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
	by vger.kernel.org with ESMTP id S1751585AbbHDC1t (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 3 Aug 2015 22:27:49 -0400
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:152:355:379:541:599:800:960:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:1801:1981:2194:2199:2393:2553:2559:2562:2693:3138:3139:3140:3141:3142:3353:3622:3865:3866:3868:3870:3872:4321:4605:5007:6119:6261:7514:7903:9036:9149:10004:10400:10848:11232:11658:11914:12517:12519:12555:12740:13069:13311:13357:13894:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0
X-HE-Tag: jewel76_26d0157a0a423
X-Filterd-Recvd-Size: 2857
Message-ID: <1438655265.10829.0.camel@perches.com>
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>
From: Joe Perches <joe@perches.com>
To: yalin wang <yalin.wang2010@gmail.com>
Cc: Don Brace <don.brace@pmcs.com>, open list <linux-kernel@vger.kernel.org>,
        iss_storagedev@hp.com, storagedev@pmcs.com,
        linux-scsi <linux-scsi@vger.kernel.org>
Date: Mon, 03 Aug 2015 19:27:45 -0700
In-Reply-To: <EB2039AE-8999-4D0F-9602-CA5ACF3F66BA@gmail.com>
References: <1438547113.29569.5.camel@perches.com>
	 <9547AF94-2168-4987-AD89-B7F111084CC2@gmail.com>
	 <1438589026.30149.15.camel@perches.com>
	 <67B9124A-73E8-4AA1-81E5-18FAC69D3962@gmail.com>
	 <EB2039AE-8999-4D0F-9602-CA5ACF3F66BA@gmail.com>
Content-Type: text/plain; charset="UTF-8"
X-Mailer: Evolution 3.12.11-0ubuntu3 
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1975
Lines: 51

On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote:
> Ping ? 
> > On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@gmail.com> wrote:
> > 
> > 
> >> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote:
> >> 
> >> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote:
> >>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote:
> >>>> 
> >>>> Correct misuse of 0x%d in logging messages.
> >>>> 
> >> []
> >>> why not use like this : dev_dbg(&h->pdev->dev, "   Max outstanding 
> >>> commands = %#x\n”  ? 
> >>> %#x will add 0x prefix automatically .
> >> 
> >> It's generally a consistency thing.
> >> A 0 value would be emitted as 0 and not 0x0.
> >> 
> > i try on my ubuntu , 
> > 
> > static int __init throtl_init(void)                                                                                                           
> >  {                                                                                
> >         printk("module init test: %#x %p\n", 0, (void *)0x123);                  
> >          return 0;                                                                   
> > 
> >  }                                                                                   
> > 
> >  module_init(throtl_init); 
> > 
> > #uname -a
> > Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
> > 
> > #dmesg
> > [259356.375586] module init test: 0x0 0000000000000123
> > 
> > it seems don’t need 0x%x for 0, just need %#x for all numbers.
> > there are lots of use like this, i can change them if needed:
> > 
> > # egrep -r  -i '0x%\d*x'  .  | wc -l 
> > 11776

I suggest not, it's not a standard usage and the 0
may be unexpected.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/