Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751744AbbHDEFD (ORCPT <rfc822;w@1wt.eu>);
	Tue, 4 Aug 2015 00:05:03 -0400
Received: from mail-pa0-f41.google.com ([209.85.220.41]:35524 "EHLO
	mail-pa0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1750735AbbHDEFA convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 4 Aug 2015 00:05:00 -0400
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 8.2 \(2098\))
Subject: Re: [TRIVIAL PATCH] block: Correct misuses of 0x%<decimal>
From: yalin wang <yalin.wang2010@gmail.com>
In-Reply-To: <1438655265.10829.0.camel@perches.com>
Date: Tue, 4 Aug 2015 12:04:53 +0800
Cc: Don Brace <don.brace@pmcs.com>, open list <linux-kernel@vger.kernel.org>,
        iss_storagedev@hp.com, storagedev@pmcs.com,
        linux-scsi <linux-scsi@vger.kernel.org>
Content-Transfer-Encoding: 8BIT
Message-Id: <3A4734B5-19C8-4A67-8298-FF6682AA5972@gmail.com>
References: <1438547113.29569.5.camel@perches.com> <9547AF94-2168-4987-AD89-B7F111084CC2@gmail.com> <1438589026.30149.15.camel@perches.com> <67B9124A-73E8-4AA1-81E5-18FAC69D3962@gmail.com> <EB2039AE-8999-4D0F-9602-CA5ACF3F66BA@gmail.com> <1438655265.10829.0.camel@perches.com>
To: Joe Perches <joe@perches.com>
X-Mailer: Apple Mail (2.2098)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2302
Lines: 67


> On Aug 4, 2015, at 10:27, Joe Perches <joe@perches.com> wrote:
> 
> On Tue, 2015-08-04 at 10:19 +0800, yalin wang wrote:
>> Ping ? 
>>> On Aug 3, 2015, at 16:56, yalin wang <yalin.wang2010@gmail.com> wrote:
>>> 
>>> 
>>>> On Aug 3, 2015, at 16:03, Joe Perches <joe@perches.com> wrote:
>>>> 
>>>> On Mon, 2015-08-03 at 15:25 +0800, yalin wang wrote:
>>>>>> On Aug 3, 2015, at 04:25, Joe Perches <joe@perches.com> wrote:
>>>>>> 
>>>>>> Correct misuse of 0x%d in logging messages.
>>>>>> 
>>>> []
>>>>> why not use like this : dev_dbg(&h->pdev->dev, "   Max outstanding 
>>>>> commands = %#x\n”  ? 
>>>>> %#x will add 0x prefix automatically .
>>>> 
>>>> It's generally a consistency thing.
>>>> A 0 value would be emitted as 0 and not 0x0.
>>>> 
>>> i try on my ubuntu , 
>>> 
>>> static int __init throtl_init(void)                                                                                                           
>>> {                                                                                
>>>        printk("module init test: %#x %p\n", 0, (void *)0x123);                  
>>>         return 0;                                                                   
>>> 
>>> }                                                                                   
>>> 
>>> module_init(throtl_init); 
>>> 
>>> #uname -a
>>> Linux ubuntu 3.16.0-38-generic #52~14.04.1-Ubuntu SMP Fri May 8 09:43:57 UTC 2015 x86_64 x86_64 x86_64 GNU/Linux
>>> 
>>> #dmesg
>>> [259356.375586] module init test: 0x0 0000000000000123
>>> 
>>> it seems don’t need 0x%x for 0, just need %#x for all numbers.
>>> there are lots of use like this, i can change them if needed:
>>> 
>>> # egrep -r  -i '0x%\d*x'  .  | wc -l 
>>> 11776
> 
> I suggest not, it's not a standard usage and the 0
> may be unexpected.
> 
ok, printk for %x  is really not compatible with glibc printf behavior,
another is %p,  printk print %p as hex but not with 0x prefix, while
printf print %p as 0x…. with prefix, is this need change ?
so we don’t need lots of 0x%p printk .









--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/