Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754635AbbHDEbt (ORCPT ); Tue, 4 Aug 2015 00:31:49 -0400 Received: from ozlabs.org ([103.22.144.67]:57085 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752312AbbHDEbs (ORCPT ); Tue, 4 Aug 2015 00:31:48 -0400 From: Rusty Russell To: Thomas Gleixner Cc: LKML , x86@kernel.org, Jiang Liu , Peter Zijlstra , Bjorn Helgaas Subject: Re: [patch 2/7] x86/lguest: Do not setup unused irq vectors In-Reply-To: References: <20150802203427.110728870@linutronix.de> <20150802203609.302168886@linutronix.de> <87pp356qaz.fsf@rustcorp.com.au> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Tue, 04 Aug 2015 13:57:07 +0930 Message-ID: <878u9r7k6c.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 980 Lines: 32 Thomas Gleixner writes: > On Mon, 3 Aug 2015, Rusty Russell wrote: >> Thomas Gleixner writes: >> > + >> > + /* Some systems map "vectors" to interrupts weirdly. Not us! */ >> > + __this_cpu_write(vector_irq[FIRST_EXTERNAL_VECTOR + irq, irq); >> >> Missing ]. > > Doh. > >> [ 17.751889] do_IRQ: 0.33 No irq handler for vector (irq -1) >> >> You broke interrupts :( > > Right, because I missed the other place which fiddles with > interrupts. Does the patch below fix the issue? Yep. I added error handling. I reworked it into two patches: one which staticizes lguest_setup_irq() and moves it up, the other of which applies your changes. Will post, you can take them... Thanks, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/