Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753108AbbHDGBX (ORCPT ); Tue, 4 Aug 2015 02:01:23 -0400 Received: from mail.savoirfairelinux.com ([209.172.62.77]:59617 "EHLO mail.savoirfairelinux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751449AbbHDGBV (ORCPT ); Tue, 4 Aug 2015 02:01:21 -0400 Date: Tue, 4 Aug 2015 02:01:18 -0400 (EDT) From: Vivien Didelot To: David Cc: netdev , linux-kernel , kernel , Guenter Roeck , andrew@lunn.ch, Florian Fainelli Message-ID: <693647000.2315.1438668078706.JavaMail.zimbra@savoirfairelinux.com> In-Reply-To: <20150803.222159.1711458384701896079.davem@davemloft.net> References: <1438566362-28786-1-git-send-email-vivien.didelot@savoirfairelinux.com> <20150803.222159.1711458384701896079.davem@davemloft.net> Subject: Re: [PATCH] net: dsa: fix EDSA frame from hwaccel frame MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.6.0_GA_1153 (ZimbraWebClient - FF39 (Linux)/8.6.0_GA_1153) Thread-Topic: fix EDSA frame from hwaccel frame Thread-Index: 4SpnaQSLaCnwY+zYYD+w/Xhcfs4j1Q== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1237 Lines: 35 Hi David, On Aug 4, 2015, at 1:21 AM, David davem@davemloft.net wrote: > From: Vivien Didelot > Date: Sun, 2 Aug 2015 21:46:02 -0400 > >> If the underlying network device features NETIF_F_HW_VLAN_CTAG_TX, >> an EDSA frame is prepended with a 802.1q header once queued. >> >> To fix this, push the VLAN tag to the payload if present, before >> checking the frame protocol. >> >> [note: we may prefer to access directly VLAN TCI from hwaccel frames, >> but this approach is simpler.] >> >> Signed-off-by: Vivien Didelot > > This is a bug fix so should target 'net', but you generated the patch > against 'net-next'. > > In any event, you should be explicit about the tree you are targetting > in order to not waste my time like this, by simply specifying the > tree in your "[PATCH xxx]" text in your subject line. Either > "[PATCH net]" or "[PATCH net-next]". Dully noted. Should I resend it? Thanks, -v -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/