Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754608AbbHDGnd (ORCPT ); Tue, 4 Aug 2015 02:43:33 -0400 Received: from mail-wi0-f169.google.com ([209.85.212.169]:34129 "EHLO mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754000AbbHDGnc (ORCPT ); Tue, 4 Aug 2015 02:43:32 -0400 MIME-Version: 1.0 In-Reply-To: <201508032346.36032.marex@denx.de> References: <38c818599e1de5530ba0fe86d262d26d737ee7a2.1438626500.git.hramrach@gmail.com> <201508032346.36032.marex@denx.de> From: Michal Suchanek Date: Tue, 4 Aug 2015 08:42:51 +0200 Message-ID: Subject: Re: [PATCH v2 1/6] mtd: spi-nor: change return value of read/write To: Marek Vasut Cc: David Woodhouse , Brian Norris , Han Xu , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Huang Shijie , Ben Hutchings , Gabor Juhos , =?UTF-8?B?QmVhbiBIdW8g6ZyN5paM5paM?= , MTD Maling List , Linux Kernel Mailing List , Hou Zhiqiang , Huang Shijie Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1870 Lines: 43 On 3 August 2015 at 23:46, Marek Vasut wrote: > On Monday, August 03, 2015 at 08:39:01 PM, Michal Suchanek wrote: >> Change the return value of spi-nor device read and write methods to >> allow returning amount of data transferred and errors as >> read(2)/write(2) does. >> >> Signed-off-by: Michal Suchanek >> --- >> include/linux/mtd/spi-nor.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/include/linux/mtd/spi-nor.h b/include/linux/mtd/spi-nor.h >> index e540952..7d782cb 100644 >> --- a/include/linux/mtd/spi-nor.h >> +++ b/include/linux/mtd/spi-nor.h >> @@ -185,9 +185,9 @@ struct spi_nor { >> int (*write_reg)(struct spi_nor *nor, u8 opcode, u8 *buf, int len, >> int write_enable); >> >> - int (*read)(struct spi_nor *nor, loff_t from, >> + ssize_t (*read)(struct spi_nor *nor, loff_t from, >> size_t len, size_t *retlen, u_char *read_buf); >> - void (*write)(struct spi_nor *nor, loff_t to, >> + ssize_t (*write)(struct spi_nor *nor, loff_t to, >> size_t len, size_t *retlen, const u_char *write_buf); >> int (*erase)(struct spi_nor *nor, loff_t offs); > > You realize that if someone does bisect and has only this patch applied, > the compiler will complain loudly about mismatching data types, right ? :) Yes, the compiler prints a warning. However, only the return value which is not used changes so it should not cause any real problem. The data type in the fsl-quadspi and m25p80 drivers is matched in the following two patches. Thanks Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/