Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932549AbbHDJal (ORCPT ); Tue, 4 Aug 2015 05:30:41 -0400 Received: from lb1-smtp-cloud3.xs4all.net ([194.109.24.22]:54031 "EHLO lb1-smtp-cloud3.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754185AbbHDJaj (ORCPT ); Tue, 4 Aug 2015 05:30:39 -0400 Message-ID: <1438680636.8734.45.camel@tiscali.nl> Subject: Re: [PATCH 2/3] iio: temperature: add max6675 thermocouple converter driver From: Paul Bolle To: Matt Porter Cc: Linux IIO List , Devicetree List , Jonathan Cameron , Rob Herring , Mark Rutland , Linux Kernel Mailing List Date: Tue, 04 Aug 2015 11:30:36 +0200 In-Reply-To: <1438635410-3757-3-git-send-email-mporter@konsulko.com> References: <1438635410-3757-1-git-send-email-mporter@konsulko.com> <1438635410-3757-3-git-send-email-mporter@konsulko.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.16.4 (3.16.4-2.fc22) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1084 Lines: 34 On ma, 2015-08-03 at 16:56 -0400, Matt Porter wrote: > --- /dev/null > +++ b/drivers/iio/temperature/max6675.c > +static const struct spi_device_id max6675_spi_ids[] = { > + {"max6675", 0}, > + {}, > +}; > +MODULE_DEVICE_TABLE(spi, max6675_spi_ids); > +MODULE_ALIAS("spi:max6675"); For the "spi" alias this is "belt and suspenders": modinfo ./max6675.ko | grep alias alias: spi:max6675 alias: acpi*:MXIM6675:* alias: of:N*T*Cmaxim,max6675* alias: spi:max6675 I'd drop the MODULE_ALIAS(). (Mark Brown made it quite clear I shouldn't nag people about the origin of the various strings used in these module aliases. So I won't. But if you'd volunteer to explain me where "max6675" might come from for the spi alias that would, at least, satisfy my curiosity.) Thanks, Paul Bolle -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/