Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932769AbbHDKDW (ORCPT ); Tue, 4 Aug 2015 06:03:22 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:33798 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932508AbbHDKDU (ORCPT ); Tue, 4 Aug 2015 06:03:20 -0400 Subject: Re: [PATCH 9/9] usb: misc: ftdi-elan: Simplify return statement To: "Karajgaonkar, Saurabh (S.)" , "srinivas.kandagatla@gmail.com" , "maxime.coquelin@st.com" , "patrice.chotard@st.com" , "stern@rowland.harvard.edu" , "gregkh@linuxfoundation.org" , "mathias.nyman@intel.com" , "balbi@ti.com" , "johan@kernel.org" , "Julia.Lawall@lip6.fr" , "khilman@linaro.org" , "rafael.j.wysocki@intel.com" , "pmladek@suse.cz" , "wsa@the-dreams.de" References: <21701034f1472a3d154c77dd8d8be017565885f6.1438678566.git.skarajga@visteon.com> Cc: "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" From: Sergei Shtylyov Message-ID: <55C08DE5.3060106@cogentembedded.com> Date: Tue, 4 Aug 2015 13:03:17 +0300 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.1.0 MIME-Version: 1.0 In-Reply-To: <21701034f1472a3d154c77dd8d8be017565885f6.1438678566.git.skarajga@visteon.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1451 Lines: 47 Hello. On 8/4/2015 12:12 PM, Karajgaonkar, Saurabh (S.) wrote: > From: Saurabh Karajgaonkar > Replace redundant variable use in return statement. > Signed-off-by: Saurabh Karajgaonkar > --- > drivers/usb/misc/ftdi-elan.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > diff --git a/drivers/usb/misc/ftdi-elan.c b/drivers/usb/misc/ftdi-elan.c > index 8ab1f8f..1545f12 100644 > --- a/drivers/usb/misc/ftdi-elan.c > +++ b/drivers/usb/misc/ftdi-elan.c > @@ -2568,11 +2568,8 @@ static int ftdi_elan_close_controller(struct usb_ftdi *ftdi, int fn) > 0x00); > if (UxxxStatus) > return UxxxStatus; > - UxxxStatus = ftdi_elan_read_config(ftdi, activePCIfn | reg, 0, > + return ftdi_elan_read_config(ftdi, activePCIfn | reg, 0, > &pcidata); Please keep the continuation line aligned by starting it under 'ftdi'. [...] > @@ -2695,11 +2692,8 @@ static int ftdi_elan_setupOHCI(struct usb_ftdi *ftdi) > } > } > if (ftdi->function > 0) { > - UxxxStatus = ftdi_elan_setup_controller(ftdi, > + return ftdi_elan_setup_controller(ftdi, > ftdi->function - 1); Likewise. [...] MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/