Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934055AbbHDMAQ (ORCPT ); Tue, 4 Aug 2015 08:00:16 -0400 Received: from mail-la0-f46.google.com ([209.85.215.46]:36352 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933939AbbHDMAM (ORCPT ); Tue, 4 Aug 2015 08:00:12 -0400 Message-ID: <55C0A949.1040406@lightnvm.io> Date: Tue, 04 Aug 2015 14:00:09 +0200 From: Matias User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Pavel Machek CC: hch@infradead.org, axboe@fb.com, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Stephen.Bates@pmcs.com, keith.busch@intel.com, =?windows-1252?Q?Javier_?= =?windows-1252?Q?Gonz=E1lez?= Subject: Re: [PATCH v6 5/5] nvme: LightNVM support References: <1438082268-13496-1-git-send-email-mb@lightnvm.io> <1438082268-13496-6-git-send-email-mb@lightnvm.io> <20150802075753.GH3720@amd> In-Reply-To: <20150802075753.GH3720@amd> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 849 Lines: 32 On 08/02/2015 09:57 AM, Pavel Machek wrote: > Hi! > >> +struct nvme_nvm_hb_rw { >> + __u8 opcode; >> + __u8 flags; >> + __u16 command_id; >> + __le32 nsid; >> + __u64 rsvd2; >> + __le64 metadata; >> + __le64 prp1; >> + __le64 prp2; >> + __le64 slba; >> + __le16 length; >> + __le16 control; >> + __le32 dsmgmt; >> + __le64 phys_addr; >> +}; > > You are not exporting this to userland, so you can get rid of "__"s. > > Pavel > > Thanks. I will get them removed. It was a leftover for when it was in the nvme uapi header. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/