Date: Tue, 4 Aug 2015 08:06:45 -0400
From: Steven Rostedt <rostedt@goodmis.org>
To: Borislav Petkov <bp@alien8.de>
Cc: Peter Zijlstra <peterz@infradead.org>, Vlastimil Babka <vbabka@suse.cz>,
        linux-kernel@vger.kernel.org, mingo@kernel.org, jasonbaron0@gmail.com,
        luto@amacapital.net, tglx@linutronix.de, will.deacon@arm.com,
        liuj97@gmail.com, rabin@rab.in, ralf@linux-mips.org,
        ddaney@caviumnetworks.com, benh@kernel.crashing.org,
        michael@ellerman.id.au, heiko.carstens@de.ibm.com, davem@davemloft.net
Subject: Re: [PATCH -v2 6/8] jump_label: Add a new static_key interface
Message-ID: <20150804080645.0f29617d@gandalf.local.home>
In-Reply-To: <20150804033733.GB31787@nazgul.tnic>
References: <20150728132055.203176565@infradead.org>
	<20150728132313.164884020@infradead.org>
	<55B87E7A.2070509@suse.cz>
	<20150729084906.GH19282@twins.programming.kicks-ass.net>
	<20150803150359.0e76b576@gandalf.local.home>
	<20150803191816.GC25159@twins.programming.kicks-ass.net>
	<20150803152810.5a7bcf06@gandalf.local.home>
	<20150803200002.GE25159@twins.programming.kicks-ass.net>
	<20150803175757.2adf3275@gandalf.local.home>
	<20150804033733.GB31787@nazgul.tnic>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1425
Lines: 56

On Tue, 4 Aug 2015 05:37:33 +0200
Borislav Petkov <bp@alien8.de> wrote:

> On Mon, Aug 03, 2015 at 05:57:57PM -0400, Steven Rostedt wrote:
> > That's implementation details, not a general concept that users will
> > need to know about.
> 
> Why?
> 
> It is a branch, regardless of which insn is used on which arch - it is
> either active and you *branch* to that code or *inactive* and you don't.
> So now it is actually what it should've been from the beginning...

I just don't like the inconsistency of the initialization and the
setting.

Either have:

 DEFINE_STATIC_KEY_TRUE()
 DEFINE_STATIC_KEY_FALSE()

and

 static_branch_set_true()
 static_branch_set_false()


or have:

 DEFINE_STATIC_KEY_ENABLED()
 DEFINE_STATIC_KEY_DISABLED()

and

 static_branch_enable()
 static_branch_disable()


But having the DEFINE_STATIC_KEY_TRUE() and static_branch_enable() is
confusing, as enable does not mean "make true"!

This may seem as bike shedding, but terminology *is* important, and
being inconsistent just makes it more probable to have bugs.

-- Steve

> 
> I realize simplifying the terminology around those jump labels/static
> branches things comes kinda unnatural now.
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/