Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756302AbbHDMZ0 (ORCPT ); Tue, 4 Aug 2015 08:25:26 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:49181 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755999AbbHDMZW (ORCPT ); Tue, 4 Aug 2015 08:25:22 -0400 Message-ID: <55C0AED0.7080303@st.com> Date: Tue, 4 Aug 2015 14:23:44 +0200 From: Patrice Chotard User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Karajgaonkar, Saurabh (S.)" , "srinivas.kandagatla@gmail.com" , "maxime.coquelin@st.com" , "stern@rowland.harvard.edu" , "gregkh@linuxfoundation.org" , "mathias.nyman@intel.com" , "balbi@ti.com" , "johan@kernel.org" , "sergei.shtylyov@cogentembedded.com" , "Julia.Lawall@lip6.fr" , "khilman@linaro.org" , "rafael.j.wysocki@intel.com" , "pmladek@suse.cz" , "wsa@the-dreams.de" CC: "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 4/9] usb: host: ehci-st: Simplify return statement References: <29a173be5ace786d064ae14c02324fee42fee06c.1438678566.git.skarajga@visteon.com> In-Reply-To: <29a173be5ace786d064ae14c02324fee42fee06c.1438678566.git.skarajga@visteon.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.48.1.198] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:5.14.151,1.0.33,0.0.0000 definitions=2015-08-04_06:2015-08-04,2015-08-04,1970-01-01 signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 49 Hi On 08/04/2015 11:10 AM, Karajgaonkar, Saurabh (S.) wrote: > From: Saurabh Karajgaonkar > > Replace redundant variable use in return statement. > > Signed-off-by: Saurabh Karajgaonkar > --- > drivers/usb/host/ehci-st.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c > index 7e4bd39..b7c5cfa 100644 > --- a/drivers/usb/host/ehci-st.c > +++ b/drivers/usb/host/ehci-st.c > @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) > struct platform_device *pdev = to_platform_device(hcd->self.controller); > struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev); > struct ehci_hcd *ehci = hcd_to_ehci(hcd); > - int retval; > u32 threshold; > > /* Set EHCI packet buffer IN/OUT threshold to 128 bytes */ > @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) > writel(threshold, hcd->regs + AHB2STBUS_INSREG01); > > ehci->caps = hcd->regs + pdata->caps_offset; > - retval = ehci_setup(hcd); > - if (retval) > - return retval; > - > - return 0; > + return ehci_setup(hcd); > } > > static int st_ehci_platform_power_on(struct platform_device *dev) Acked-by: Patrice Chotard Thanks Patrice -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/