Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756532AbbHDNqH (ORCPT ); Tue, 4 Aug 2015 09:46:07 -0400 Received: from mail-io0-f173.google.com ([209.85.223.173]:35190 "EHLO mail-io0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752449AbbHDNqE (ORCPT ); Tue, 4 Aug 2015 09:46:04 -0400 MIME-Version: 1.0 In-Reply-To: References: Date: Tue, 4 Aug 2015 06:46:03 -0700 X-Google-Sender-Auth: JIr2CFBClwSg5r8aO8HH_UOYDiM Message-ID: Subject: Re: kdbus: to merge or not to merge? From: Linus Torvalds To: David Herrmann Cc: Andy Lutomirski , "linux-kernel@vger.kernel.org" , Djalal Harouni , Greg KH , Havoc Pennington , "Eric W. Biederman" , One Thousand Gnomes , Tom Gundersen , Daniel Mack , "Kalle A. Sandstrom" , Borislav Petkov , cee1 Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 811 Lines: 20 On Tue, Aug 4, 2015 at 1:58 AM, David Herrmann wrote: > > You lack a call to sd_bus_unref() here. I assume it was intentional. Why would Andy talk about "scaling" otherwise? And the worry was why the kdbus version killed the machine, but the userspace version did not. That's a rather big difference, and not a good one. Possibly the kdbus version ends up not just allocating user space memory (which we should handle gracefully), but kernel allocations too (which absolutely have to be explicitly resource-managed). Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/