Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756608AbbHDNti (ORCPT ); Tue, 4 Aug 2015 09:49:38 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:34483 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756284AbbHDNth (ORCPT ); Tue, 4 Aug 2015 09:49:37 -0400 Date: Tue, 4 Aug 2015 15:49:33 +0200 From: Daniel Vetter To: Geert Uytterhoeven Cc: David Airlie , Geert Uytterhoeven , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH 0/2] drm/fb-helper: Silence defined but not used warning Message-ID: <20150804134933.GJ24689@phenom.ffwll.local> Mail-Followup-To: Geert Uytterhoeven , David Airlie , Geert Uytterhoeven , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <1438694531-11116-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1438694531-11116-1-git-send-email-geert@linux-m68k.org> X-Operating-System: Linux phenom 4.2.0-rc1+ User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1765 Lines: 55 On Tue, Aug 04, 2015 at 03:22:09PM +0200, Geert Uytterhoeven wrote: > From: Geert Uytterhoeven > > Hi, > > If CONFIG_MAGIC_SYSRQ is not set: > > drivers/gpu/drm/drm_fb_helper.c:390:13: warning: 'drm_fb_helper_force_kernel_mode' defined but not used [-Wunused-function] > static bool drm_fb_helper_force_kernel_mode(void) > ^ > > As just silencing this warning would require moving two functions (one > of them having obsolete documentation) inside the #ifdef, I fixed the > documentation first. > > This patch series is against next-20150803. > > Geert Uytterhoeven (2): > drm/fb-helper: Clarify drm_fb_helper_restore_fbdev_mode*() > drm/fb-helper: Move drm_fb_helper_force_kernel_mode() inside #ifdef Thanks, both applied to drm-misc. -Daniel > > drivers/gpu/drm/drm_fb_helper.c | 71 ++++++++++++++++------------------------- > 1 file changed, 28 insertions(+), 43 deletions(-) > > -- > 1.9.1 > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/