Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934344AbbHDODA (ORCPT ); Tue, 4 Aug 2015 10:03:00 -0400 Received: from mail-am1on0117.outbound.protection.outlook.com ([157.56.112.117]:27200 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933124AbbHDOC6 convert rfc822-to-8bit (ORCPT ); Tue, 4 Aug 2015 10:02:58 -0400 From: "Karajgaonkar, Saurabh (S.)" To: "srinivas.kandagatla@gmail.com" , "maxime.coquelin@st.com" , "patrice.chotard@st.com" , "stern@rowland.harvard.edu" , "gregkh@linuxfoundation.org" , "mathias.nyman@intel.com" , "balbi@ti.com" , "johan@kernel.org" , "sergei.shtylyov@cogentembedded.com" , "Julia.Lawall@lip6.fr" , "khilman@linaro.org" , "rafael.j.wysocki@intel.com" , "pmladek@suse.cz" , "wsa@the-dreams.de" CC: "linux-arm-kernel@lists.infradead.org" , "kernel@stlinux.com" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: [PATCH v2 4/9] usb: host: ehci-st: Simplify return statement Thread-Topic: [PATCH v2 4/9] usb: host: ehci-st: Simplify return statement Thread-Index: AQHQzr5CL32D4kLIqU2h1ydOPjOeQw== Date: Tue, 4 Aug 2015 14:02:55 +0000 Message-ID: <29a173be5ace786d064ae14c02324fee42fee06c.1438695318.git.skarajga@visteon.com> References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=skarajga@visteon.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [74.112.167.117] x-microsoft-exchange-diagnostics: 1;DBXPR06MB381;5:uAyvfyss8CtieAC/JO5XqwiaEkMULHdvnJS1KolfupVcQwRcrK6mj45T0WE7IfdAXxYubI6RkmePEBj+ttyhb69EuRjquVHg+xJGD7s6zTfVrx8qwGk27KG+wtC6fvUan8kRsTWSHNXia1wSrdnpFA==;24:jKmTACxT6nK2bMddOnrJNONlGrucGh23qTaeSW8y4TzsevB5dzyooHeb2aecQ+x9LMfkzfK/qB7bh5NngK/YlYmqDXQLQo0hJsyHiEVhKbI=;20:BAl7F81Bg5sNhYYX/3SrMHJf8DV/YIRVJqsNGKgj2fTD0RBhSk7oniIwBUfVL0XfAsNJasFu8fTZicR3xXPfvA== x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DBXPR06MB381; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:DBXPR06MB381;BCL:0;PCL:0;RULEID:;SRVR:DBXPR06MB381; x-forefront-prvs: 0658BAF71F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(189002)(199003)(77156002)(106356001)(118296001)(229853001)(101416001)(33646002)(106116001)(19580395003)(46102003)(2656002)(62966003)(87936001)(86362001)(2201001)(2171001)(122556002)(54356999)(66066001)(36756003)(5001770100001)(2900100001)(5002640100001)(5001860100001)(2950100001)(40100003)(105586002)(77096005)(5001920100001)(76176999)(189998001)(102836002)(2501003)(5001830100001)(64706001)(19580405001)(92566002)(4001540100001)(68736005)(50986999)(81156007)(97736004)(5001960100002)(921003)(1121003);DIR:OUT;SFP:1102;SCL:1;SRVR:DBXPR06MB381;H:DBXPR06MB382.eurprd06.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; spamdiagnosticoutput: 1:23 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="us-ascii" Content-ID: <3F2B8577E2469A4AB911C4934124224C@eurprd06.prod.outlook.com> Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-OriginatorOrg: visteon.com X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Aug 2015 14:02:55.4390 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 7a147aaf-01ec-498c-80a1-e34a8c63c548 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBXPR06MB381 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1373 Lines: 41 From: Saurabh Karajgaonkar Replace redundant variable use in return statement. Signed-off-by: Saurabh Karajgaonkar --- drivers/usb/host/ehci-st.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/usb/host/ehci-st.c b/drivers/usb/host/ehci-st.c index 7e4bd39..b7c5cfa 100644 --- a/drivers/usb/host/ehci-st.c +++ b/drivers/usb/host/ehci-st.c @@ -54,7 +54,6 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) struct platform_device *pdev = to_platform_device(hcd->self.controller); struct usb_ehci_pdata *pdata = dev_get_platdata(&pdev->dev); struct ehci_hcd *ehci = hcd_to_ehci(hcd); - int retval; u32 threshold; /* Set EHCI packet buffer IN/OUT threshold to 128 bytes */ @@ -62,11 +61,7 @@ static int st_ehci_platform_reset(struct usb_hcd *hcd) writel(threshold, hcd->regs + AHB2STBUS_INSREG01); ehci->caps = hcd->regs + pdata->caps_offset; - retval = ehci_setup(hcd); - if (retval) - return retval; - - return 0; + return ehci_setup(hcd); } static int st_ehci_platform_power_on(struct platform_device *dev) -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/