Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757759AbbHDP0w (ORCPT ); Tue, 4 Aug 2015 11:26:52 -0400 Received: from mx2.suse.de ([195.135.220.15]:58782 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753223AbbHDOlL (ORCPT ); Tue, 4 Aug 2015 10:41:11 -0400 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Dan Carpenter , Suman Anna , Greg Kroah-Hartman , Omar Ramirez Luna , Andrew Morton , Linus Torvalds , Oliver Neukum , Jiri Slaby Subject: [PATCH 3.12 002/123] drivers/mailbox/omap: make mbox->irq signed for error handling Date: Tue, 4 Aug 2015 16:39:06 +0200 Message-Id: <7562c6fb07eadc6d0d9b6643dadad3d20af4d867.1438699154.git.jslaby@suse.cz> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1568 Lines: 49 From: Dan Carpenter 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit 4a102b4d144f0422eb8b0a59c7cb194bf12163a9 upstream. There is a bug in omap2_mbox_probe() where we try do: mbox->irq = platform_get_irq(pdev, info->irq_id); if (mbox->irq < 0) { The problem is that mbox->irq is unsigned so the error handling doesn't work. I've changed it to a signed integer. Signed-off-by: Dan Carpenter Cc: Suman Anna Cc: Greg Kroah-Hartman Cc: Omar Ramirez Luna Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Cc: Oliver Neukum Signed-off-by: Jiri Slaby --- drivers/mailbox/omap-mbox.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mailbox/omap-mbox.h b/drivers/mailbox/omap-mbox.h index 6cd38fc68599..86d7518cd13b 100644 --- a/drivers/mailbox/omap-mbox.h +++ b/drivers/mailbox/omap-mbox.h @@ -52,7 +52,7 @@ struct omap_mbox_queue { struct omap_mbox { const char *name; - unsigned int irq; + int irq; struct omap_mbox_queue *txq, *rxq; struct omap_mbox_ops *ops; struct device *dev; -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/