Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935004AbbHDPMs (ORCPT ); Tue, 4 Aug 2015 11:12:48 -0400 Received: from mx2.suse.de ([195.135.220.15]:58910 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932109AbbHDOl3 (ORCPT ); Tue, 4 Aug 2015 10:41:29 -0400 X-Amavis-Alert: BAD HEADER SECTION, Duplicate header field: "References" From: Jiri Slaby To: stable@vger.kernel.org Cc: linux-kernel@vger.kernel.org, "Darrick J. Wong" , "Theodore Ts'o" , Jiri Slaby Subject: [PATCH 3.12 041/123] ext4: don't retry file block mapping on bigalloc fs with non-extent file Date: Tue, 4 Aug 2015 16:39:45 +0200 Message-Id: <671aeca6810e565116cdcea608d17b13c3fd8a65.1438699154.git.jslaby@suse.cz> X-Mailer: git-send-email 2.5.0 In-Reply-To: References: In-Reply-To: References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1513 Lines: 43 From: "Darrick J. Wong" 3.12-stable review patch. If anyone has any objections, please let me know. =============== commit 292db1bc6c105d86111e858859456bcb11f90f91 upstream. ext4 isn't willing to map clusters to a non-extent file. Don't signal this with an out of space error, since the FS will retry the allocation (which didn't fail) forever. Instead, return EUCLEAN so that the operation will fail immediately all the way back to userspace. (The fix is either to run e2fsck -E bmap2extent, or to chattr +e the file.) Signed-off-by: Darrick J. Wong Signed-off-by: Theodore Ts'o Signed-off-by: Jiri Slaby --- fs/ext4/indirect.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ext4/indirect.c b/fs/ext4/indirect.c index c30cbe291e30..fed626faeecd 100644 --- a/fs/ext4/indirect.c +++ b/fs/ext4/indirect.c @@ -576,7 +576,7 @@ int ext4_ind_map_blocks(handle_t *handle, struct inode *inode, EXT4_FEATURE_RO_COMPAT_BIGALLOC)) { EXT4_ERROR_INODE(inode, "Can't allocate blocks for " "non-extent mapped inodes with bigalloc"); - return -ENOSPC; + return -EUCLEAN; } goal = ext4_find_goal(inode, map->m_lblk, partial); -- 2.5.0 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/